Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cabal.Distribution.PackageDescription.Check should be factored per component #2065

Closed
ezyang opened this issue Aug 28, 2014 · 2 comments · Fixed by #8427
Closed

Cabal.Distribution.PackageDescription.Check should be factored per component #2065

ezyang opened this issue Aug 28, 2014 · 2 comments · Fixed by #8427
Labels
Cabal: other cabal-install: cmd/check old-milestone: ⊥ Moved from https://github.com/haskell/cabal/milestone/5 type: refactor
Milestone
⊥

Comments

@ezyang
Copy link
Contributor

ezyang commented Aug 28, 2014

Right now Cabal.Distribution.PackageDescription.Check operates on a sort of ad hoc basis, calling allBuildInfo to implement various checks. This means that there are few cases where we completely forget to validate fields at all, especially build-depends in stanzas. Instead, we should have a function which validates a BuildInfo, and call it on each of the build-infos.
@ezyang ezyang mentioned this issue Aug 28, 2014
Merged
@ezyang ezyang added the bug label Aug 28, 2014
@ttuegel ttuegel added this to the _|_ milestone Apr 24, 2015
@ulysses4ever
Copy link
Collaborator

@ffaf1 could I ask you to take a brief look at this ticket and say if it still makes sense?

@ffaf1
Copy link
Collaborator

ffaf1 commented Oct 6, 2023

This will be fixed when #8427 is merged.

@ffaf1 ffaf1 mentioned this issue Oct 6, 2023
Merged
4 tasks
@ffaf1 ffaf1 linked a pull request Oct 6, 2023 that will close this issue
Reimplement cabal check #8427
Merged
4 tasks
@andreabedini andreabedini added the old-milestone: ⊥ Moved from https://github.com/haskell/cabal/milestone/5 label Oct 17, 2023
@mergify mergify bot closed this as completed in #8427 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cabal: other cabal-install: cmd/check old-milestone: ⊥ Moved from https://github.com/haskell/cabal/milestone/5 type: refactor
Projects
None yet
Milestone
⊥
Development

Successfully merging a pull request may close this issue.

Reimplement cabal check ffaf1/cabal
5 participants
@ezyang @andreabedini @ttuegel @ulysses4ever @ffaf1