Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the standard commands use the sandbox, if present #1104

Closed
tibbe opened this issue Nov 8, 2012 · 11 comments
Closed

Have the standard commands use the sandbox, if present #1104

tibbe opened this issue Nov 8, 2012 · 11 comments
Assignees

Comments

@tibbe
Copy link
Member

tibbe commented Nov 8, 2012

Currently the sandbox can only be used through the temporary and hidden sandbox family of commands. These commands should be merged into their corresponding non-sandbox commands, which should check for the presence of a sandbox and use it, if present.

@ghost ghost assigned 23Skidoo Nov 8, 2012
@tibbe
Copy link
Member Author

tibbe commented Jan 15, 2013

Note that there's currently no e.g. cabal sandbox-bench command. We need to make sure that bench and test work as expected once the UI has been merged.

@23Skidoo
Copy link
Member

I'll be away during the next ten days, won't be able to work on the remaining issues during this period.

@23Skidoo
Copy link
Member

A bit unfortunate that the Hackage wiki is offline since we had the design document there.

@tibbe
Copy link
Member Author

tibbe commented Feb 25, 2013

I checked if Google's cache had it but no luck. I think the behavior is pretty straight-forward though. cabal configure behaves like today's cabal configure if no sandbox is present and as today's cabal sandbox-configure if a sandbox is present. Same for the other commands.

We'll have some commands for managing the sandbox, like cabal sandbox init, cabal sandbox add-source, cabal sandbox remove-source, etc.

@23Skidoo
Copy link
Member

Yes, that part I remember. I was just wondering if there was some information there that I forgot.

@23Skidoo
Copy link
Member

With regard to subcommands (such as cabal sandbox init) - should I just parse extraArgs in sandboxAction or would it be better to add support for subcommands to D.S.Command?

@tibbe
Copy link
Member Author

tibbe commented Feb 28, 2013

Supporting subcommands in D.S.Command would be ideal, but if it's too disruptive we can start with just using extraArgs (but still using D.S.Command to parse those, if that makes sense).

@23Skidoo
Copy link
Member

I've moved the design docs to the new wiki: Package Environments, Sandboxed Builds and Isolated Environments.

@tibbe
Copy link
Member Author

tibbe commented Mar 20, 2013

@23Skidoo Great, thanks. Could you leave a pointer to the branch you're working on here for reference?

@23Skidoo
Copy link
Member

@tibbe
Copy link
Member Author

tibbe commented Apr 12, 2013

Done in #1256

@tibbe tibbe closed this as completed Apr 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants