Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it feasible to qualify imports from Prelude? #127

Open
JustusAdam opened this issue Oct 4, 2018 · 2 comments
Open

Is it feasible to qualify imports from Prelude? #127

JustusAdam opened this issue Oct 4, 2018 · 2 comments
Labels
feature request help wanted re: qualified imports Generated code should import qualified to not clash with user definitions

Comments

@JustusAdam
Copy link

Problem

I happen to use Alex in a context where I have a custom Prelude and also
warnings enabled for the use of undefined and to top things off I use
--pedantic when compiling on CI.

So basically its a bit inconvenient.

My question therefore is would it not be better perhaps to only use fully
qualified imports and fully qualified names in the templates/lexers to avoid
potential clashes with user imports/defines?

Solution

Because this is a very minor issue I'd happily take it upon myself to
"implement" it, so long as there are no objections.

@simonmar
Copy link
Member

Yes, I think this would be good. I'll gladly accept a PR that fully qualifies everything.

@andreasabel andreasabel added re: qualified imports Generated code should import qualified to not clash with user definitions feature request help wanted labels Apr 14, 2023
@andreasabel
Copy link
Member

@JustusAdam Would you still be up for this?
I added qualification for all non-Prelude imports in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request help wanted re: qualified imports Generated code should import qualified to not clash with user definitions
Projects
None yet
Development

No branches or pull requests

3 participants