Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting X25519 and X448 #204

Closed
kazu-yamamoto opened this issue Apr 5, 2017 · 1 comment
Closed

Supporting X25519 and X448 #204

kazu-yamamoto opened this issue Apr 5, 2017 · 1 comment

Comments

@kazu-yamamoto
Copy link
Collaborator

kazu-yamamoto commented Apr 5, 2017

https://tools.ietf.org/html/draft-ietf-tls-rfc4492bis defines:

         enum {
               deprecated(1..22),
               secp256r1 (23), secp384r1 (24), secp521r1 (25),
               x25519(29), x448(30),
               reserved (0xFE00..0xFEFF),
               deprecated(0xFF01..0xFF02),
               (0xFFFF)
           } NamedCurve;

So, I would like to do two things:

  • Removing named curves from 1 to 22
  • Supporting X25519 and X448 based on my TLS 1.3 branch

When my TLS 1.3 client sends a list of named curves including X25519, some TLS 1.2 server return it and the client got a pattern match failure.

% tls-simpleclient -O html-log.txt --http1.1 nghttp2.org 443          
groups = [X448,X25519,P256], keyshare = [X448]
tls-simpleclient: HandshakeFailed (Error_Misc "Network/TLS/Crypto/ECDH.hs:43:5-31: Irrefutable pattern failed for pattern Just name\n")

I want to fix this issue.

@kazu-yamamoto
Copy link
Collaborator Author

#205 resolved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant