Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cereal remote, server side integration #255

Merged
merged 61 commits into from
Nov 30, 2023
Merged

cereal remote, server side integration #255

merged 61 commits into from
Nov 30, 2023

Conversation

sorki
Copy link
Member

@sorki sorki commented Nov 23, 2023

@sorki sorki added the remote `hnix-store-remote` related label Nov 23, 2023
@sorki sorki mentioned this pull request Nov 24, 2023
Merged
@sorki sorki force-pushed the srk/daemon branch 6 times, most recently from 6e0defd to b393541 Compare November 25, 2023 19:44
@sorki sorki mentioned this pull request Nov 29, 2023
Closed
@sorki
Copy link
Member Author

sorki commented Nov 30, 2023

@squalus Arbitrary Signature instance was quite helpful to allow Arbitrary (Metadata StorePath), thanks for adding that!

sorki and others added 18 commits November 30, 2023 06:59
@sorki
remote: sort deps in cabal file
a2397f5
@Ericson2314 @danbornside @sorki
Bidirectional worker op
ca5faba 
Use dummy enum variants to fill the gaps so the Enum instance works

Co-Authored-By: Dan Bornside <[email protected]>
@Ericson2314 @sorki
remote: add ProtoVersion
e4271d6
@sorki
remote: squash whitespace
655afaa
@sorki
remote: complete binary -> cereal transition
93d923e
@sorki
remote: move WorkerOp to Types.WorkerOp
7590e2b
@Ericson2314 @sorki
remote: move StoreConfig to Types.StoreConfig, extend, add PreStoreCo…
ab201da 
…nfig
@Ericson2314 @sorki
remote: Util -> Socket
7cd4add
@sorki
remote: move and rename (CheckFlag|SubstituteFlag) to Types.(Check|Su…
4f40e05 
…bstitude)Mode
@sorki
remote: Types.Logger
7604080
@Ericson2314 @sorki
remote: move StoreMonad to MonadStore
64a4368
@sorki
remote: add Types.Verbosity
96cbe11
@sorki
remote: expand Logger with fields
cb255d4
@sorki
remote: add Arbitrary, Verbosity prop and enum tests
a3e3840
@sorki
prefix BuildMode and BuildResult constructors
5ea5b82
@sorki
remote: Arbitrary and Serialize for ActivityID, Field, props
0a0e4a6
@sorki
remote: parallel tests
25bd0f1
@sorki
remote: safer getBool, getEnum
9ac9d49
sorki and others added 24 commits November 30, 2023 06:59
@sorki
remote: set ourProtoVersion minor to what we currently advertise
d15f007
@sorki
remote: handle both error types in logger
bb5f116
@sorki
remote: bark if parsing leftover isn't empty
a2c5065
@sorki
remote: add path serializer, start wiring errors
edace04
@sorki
remote: add build-derivation executable
2e9ab69
@sorki
remote: better errors for bool and enum serializers
da8eb42
@squalus @sorki
remote: add deleteSpecific
922f5bb 
- add the gcDeleteSpecific action of the CollectGarbage operation.
- add deleteSpecific test
@sorki
remote: more error handling, port rest of the logger to Serializer
c853163
@sorki
remote: port the rest to Serializer
69135ed
@sorki
remote: replace protoVersion, use new toys
5ebe47d
@cgibbard @sorki
remote: add derivedPath Serializer
c8a329b 
Co-Authored-By: sorki <[email protected]>
@sorki
remote: rest of the Prim/Serialize -> Serializer
e950c84
@sorki
core: derive classics for BaseEncoding enum
1702fa0
@sorki
core: Cryptonite -> Crypton in error message
b3a77ea
@sorki
core: add unsafeMakeStorePathHashPart
2e54e33
@sorki
tests: add Arbitrary BaseEncoding
9b16abb
@sorki
tests: add Arbitrary (Some HashAlgo)
2e4e83c
@sorki
tests: add Arbitrary StorePathTrust, Arbitrary (Metadata StorePath)
a9be986
@sorki
tests: shave off other hashes todo for StorePathHashPart
ee4049d
@sorki
remote: add remaining Serializers
90984fd 
* storePathHashPart
* storePathName
* pathMetadata
* someHashAlgo
* digest
@sorki
remote: storeMetadata, add signature Serializer
598cb89
@sorki
remote, add Types.GC, use in deleteSpecific
9cd7d35
@sorki
remote: cabal, sort exposed modules
849f7e7
@sorki
Update CI, no on: pull_request by default
c8bbf5f
@sorki
Copy link
Member Author

sorki commented Nov 30, 2023

Serializer done, error handling done, GC done, build-derivation executable is broken but easy to fix but if I move ourProtoVersion some tests start to fail, will resolve in next PR.

Progressing slowly but the gradual refactoring without breaking tests is the way to go, the rest should land swiftly.

@sorki sorki merged commit 70eb0d3 into master Nov 30, 2023
10 checks passed
@sorki sorki mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
remote `hnix-store-remote` related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorki @Ericson2314 @squalus @cgibbard