hlint is hard-coded to be installed on GHC 8.4.3 (not the latest GHC)

[RyanGlScott]

haskell-ci/make_travis_yml_2.hs

Lines 812 to 814 in a9a6103

	when (cfgHLint config) $ tellStrLns
	[ sh $ "if [ $HCNUMVER -eq 80403 ]; then cabal new-install -w ${HC} -j2 --symlink-bindir=$HOME/.local/bin hlint" ++ hlintVersionConstraint ++ "; fi"
	]

The code is hard-coding the use of 80403. This should probably be $LATEST_COMPILER instead so that it stays up to date with the latest GHC releases (such as 8.6.1, for instance).

There are a couple of other lines of code in haskell-ci that also exhibit this problem.

[phadej]

I think the job HLint ruma have to be configurable, but could be the "latest stable" in the list.

…

Sent from my iPhone

On 23 Sep 2018, at 0.42, Ryan Scott ***@***.***> wrote: https://github.com/haskell-CI/haskell-ci/blob/a9a61032ca0ca2776659a5035c6f348e43bf2657/make_travis_yml_2.hs#L812-L814 The code is hard-coding the use of 80403. This should probably be $LATEST_COMPILER instead so that it stays up to date with the latest GHC releases (such as 8.6.1, for instance). There are a couple of other lines of code in haskell-ci that also exhibit this problem. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[RyanGlScott]

Sure, by all means let this be a configuration option—anything else is better than how it works now :)

[RyanGlScott]

I looked into implementing this recently. My game plan is to have a revamped --hlint (and --doctest) flag with three possible states, as represented by this data type:

-- | Used to implement the @--hlint@ and @--doctest@ flags.
data RunProgramOptions
  = Don'tRunProgram
    -- ^ Don't run the program at all.
    --   (e.g., the @--hlint@ flag wasn't passed).
  | RunProgramUsingLatest
    -- ^ Run the program, but only when using the latest version of GHC in the
    --   @tested-with@ stanza.
    --   (e.g., the @--hlint@ flag was passed with no arguments).
  | RunProgramUsingVersionRange VersionRange
    -- ^ Run the program, but only when the version of GHC being used falls
    --   within the provided version range.
    --   (e.g, @--hlint=\"==8.4.3\"@).

There's one annoying problem that I ran into, however. In addition to the --hlint flag, one can also specify an hlint stanza in a configuration file (e.g., hlint: True). However, this uses a completely different configuration language (some data type called FieldDescr that I've never heard of before) than what the CLI flags use (System.Console.GetOpt).

What would a FieldDescr counterpart to the revamped hlint flag look like? It's clear that Don'tRunProgram (i.e., not passing --hlint) would correspond to not giving an hlint stanza, and RunProgramUsingVersionRange (i.e., --hlint="==8.4.3") would correspond to something like hlint: == 8.4.3. But what would RunProgramUsingLatest correspond to? I have no idea, and I can't even find out what FieldDescr is on Hackage, so I'm a bit stuck here.

[peti]

A solution to this issue would be very much appreciated. I recently updated my test builds from ghc 8.4.3 to 8.4.4 and was unpleasantly surprised by the fact that this means hlint won't be running any more.

Personally, I believe that specifying --hlint for a configuration that actually doesn't include ghc-8.4.3 should abort the tool with an error because no valid configuration that satisfies these options can be generated.

[phadej]

Fixed in #204