From 5b052250979195bfd2bec7376e731b8ce9eb9eda Mon Sep 17 00:00:00 2001 From: xntrik Date: Tue, 17 Dec 2019 12:20:20 +0800 Subject: [PATCH 1/4] UI update headless chrome flags to fix ember/chrome crash in test --- ui/testem.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/testem.js b/ui/testem.js index fff07eb97a4c..e41846568dc4 100644 --- a/ui/testem.js +++ b/ui/testem.js @@ -10,7 +10,8 @@ const config = { // --no-sandbox is needed when running Chrome inside a container process.env.CI ? '--no-sandbox' : null, '--headless', - '--disable-gpu', + // as per https://github.com/ember-cli/ember-cli/pull/8774 + //'--disable-gpu', '--disable-software-rasterizer', '--mute-audio', '--remote-debugging-port=0', From 2434b437d01c2459d595982c61c55f47770ac159 Mon Sep 17 00:00:00 2001 From: xntrik Date: Tue, 17 Dec 2019 12:21:04 +0800 Subject: [PATCH 2/4] UI update references from test-oss to test:oss --- Makefile | 2 +- ui/README.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 09fc9e700c2b..d09244f83e51 100644 --- a/Makefile +++ b/Makefile @@ -150,7 +150,7 @@ test-ember: @echo "--> Installing JavaScript assets" @cd ui && yarn --ignore-optional @echo "--> Running ember tests" - @cd ui && yarn run test-oss + @cd ui && yarn run test:oss ember-ci-test: # Deprecated, to be removed soon. @echo "ember-ci-test is deprecated in favour of test-ui-browserstack" diff --git a/ui/README.md b/ui/README.md index 9bcbfee1a1d4..c4e1d8352ba9 100644 --- a/ui/README.md +++ b/ui/README.md @@ -72,8 +72,8 @@ Running tests will spin up a Vault dev server on port 9200 via a pretest script that testem (the test runner) executes. All of the acceptance tests then run, proxing requests back to that server. -- `yarn run test-oss` -- `yarn run test-oss -s` to keep the test server running after the initial run. +- `yarn run test:oss` +- `yarn run test:oss -s` to keep the test server running after the initial run. - `yarn run test -f="policies"` to filter the tests that are run. `-f` gets passed into [QUnit's `filter` config](https://api.qunitjs.com/config/QUnit.config#qunitconfigfilter-string--default-undefined) - `yarn run test:browserstack` to run the kv acceptance tests in Browserstack From 87ba8ac64f645e64b49a0a166d3002ff7be1e7ad Mon Sep 17 00:00:00 2001 From: xntrik Date: Wed, 18 Dec 2019 10:45:41 +0800 Subject: [PATCH 3/4] UI removed disable-gpu flag from headless Chrome --- ui/testem.js | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/testem.js b/ui/testem.js index e41846568dc4..4202d0a97a8c 100644 --- a/ui/testem.js +++ b/ui/testem.js @@ -11,7 +11,6 @@ const config = { process.env.CI ? '--no-sandbox' : null, '--headless', // as per https://github.com/ember-cli/ember-cli/pull/8774 - //'--disable-gpu', '--disable-software-rasterizer', '--mute-audio', '--remote-debugging-port=0', From c6911779b3bc561c5e2971620e2f6587c52da697 Mon Sep 17 00:00:00 2001 From: xntrik Date: Wed, 18 Dec 2019 12:45:21 +0800 Subject: [PATCH 4/4] UI and also remove the comment --- ui/testem.js | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/testem.js b/ui/testem.js index 4202d0a97a8c..49392576544c 100644 --- a/ui/testem.js +++ b/ui/testem.js @@ -10,7 +10,6 @@ const config = { // --no-sandbox is needed when running Chrome inside a container process.env.CI ? '--no-sandbox' : null, '--headless', - // as per https://github.com/ember-cli/ember-cli/pull/8774 '--disable-software-rasterizer', '--mute-audio', '--remote-debugging-port=0',