Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsorted list of secrets in UI for Generic/KV version 1 #5141

Closed
Garath620 opened this issue Aug 20, 2018 · 5 comments
Closed

Unsorted list of secrets in UI for Generic/KV version 1 #5141

Garath620 opened this issue Aug 20, 2018 · 5 comments
Labels

Comments

@Garath620
Copy link

Describe the bug
Vault UI displays an unsorted list of secrets for Generic/KV V1 secret store.

Expected behavior
The list of secret should be sorted alphabetically like in KV V2 secret store.

Environment:

  • Vault Server Version 0.10.4
@jefferai jefferai added the ui label Aug 20, 2018
@briankassouf
Copy link
Contributor

Which storage backend are you using?

@Garath620
Copy link
Author

I use Filesystem Storage Backend.
I try with vault server in dev mode and the list of secret is sorted correctly.

@jefferai
Copy link
Member

Just to be clear, "sorted correctly" implies that there is a sorting order. There's not. It just so happens that most storage implementations, when listing, will return a sorted set of strings.

At this point, it's unclear whether you're describing a desired improvement to the file storage engine, or if you are raising some kind of issue with the UI. I don't know of any reason that V1/V2 would behave differently.

@Garath620
Copy link
Author

Hello @jefferai

I create a kv secrets engine v1 and an other in v2.
vault secrets enable -path=testsort -version=1 kv
vault secrets enable -path=testsort2 -version=2 kv
I put same data into and in UI I see this :
sortkv1
sortkv2

jefferai added a commit that referenced this issue Aug 24, 2018
We do this already in the CLI, but because we do it there the UI doesn't
have ordered responses.

We could put it in the UI, but it seems like we might as well just make
it nice for all API users.

Fixes #5141
jefferai added a commit that referenced this issue Aug 24, 2018
We do this already in the CLI, but because we do it there the UI doesn't
have ordered responses.

We could put it in the UI, but it seems like we might as well just make
it nice for all API users.

Fixes #5141
@Garath620
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants