storage consul - enforce service regex or (RFC 1123)

[latchmihay]

When using storage consul you can specify service name. That service name should be following the RFC 1123 or at least a similar regex.

This check is already in place for nomad service checks
* service name must be valid per RFC 1123 and can contain only alphanumeric characters or dashes: "blabla_vault")

Environment:

All

Vault Config File:

storage "consul" {
  address = "127.0.0.1:8500"
  path = "blabla_vault"
  service = "blabla_vault"
  redirect_addr = "https://10.10.10.10:8200"
}

Startup Log Output:

Expected Behavior:

Actual Behavior:

Steps to Reproduce:

Important Factoids:

References: