diff --git a/changelog/25209.txt b/changelog/25209.txt new file mode 100644 index 000000000000..178a09cbc8d3 --- /dev/null +++ b/changelog/25209.txt @@ -0,0 +1,3 @@ +```release-note:bug +ui: Fix inconsistent empty state action link styles +``` \ No newline at end of file diff --git a/ui/app/components/clients/no-data.hbs b/ui/app/components/clients/no-data.hbs index 7f3ffeb1dc53..e988f82440c1 100644 --- a/ui/app/components/clients/no-data.hbs +++ b/ui/app/components/clients/no-data.hbs @@ -14,11 +14,12 @@ @message="Tracking is disabled, and no data is being collected. To turn it on, edit the configuration." > {{#if @config.canEdit}} -

- - Go to configuration - -

+ {{/if}} {{/if}} \ No newline at end of file diff --git a/ui/app/templates/components/dashboard/quick-actions-card.hbs b/ui/app/templates/components/dashboard/quick-actions-card.hbs index 0b4e2d35090b..d936a913c149 100644 --- a/ui/app/templates/components/dashboard/quick-actions-card.hbs +++ b/ui/app/templates/components/dashboard/quick-actions-card.hbs @@ -92,9 +92,12 @@ @message="Access secret engine actions easily. Enable a compatible secret engine (such as database, KV version 2, or PKI) to get started." data-test-empty-state="quick-actions" > -
- Enable a secret engine -
+ {{/if}} \ No newline at end of file diff --git a/ui/app/templates/components/dashboard/replication-card.hbs b/ui/app/templates/components/dashboard/replication-card.hbs index fb899e351097..2aeaaa2444c3 100644 --- a/ui/app/templates/components/dashboard/replication-card.hbs +++ b/ui/app/templates/components/dashboard/replication-card.hbs @@ -89,9 +89,12 @@ class="has-top-margin-m" data-test-empty-state="replication" > -
- Enable replication -
+ {{/if}} \ No newline at end of file diff --git a/ui/app/templates/components/dashboard/secrets-engines-card.hbs b/ui/app/templates/components/dashboard/secrets-engines-card.hbs index 140f1e1bcca2..3eb7756da780 100644 --- a/ui/app/templates/components/dashboard/secrets-engines-card.hbs +++ b/ui/app/templates/components/dashboard/secrets-engines-card.hbs @@ -88,9 +88,12 @@ class="has-top-margin-m" data-test-empty-state="secrets-engines" > -
- Enable a secret engine -
+ {{/if}} \ No newline at end of file diff --git a/ui/app/templates/components/database-connection.hbs b/ui/app/templates/components/database-connection.hbs index fef202ec9e64..33fd83363435 100644 --- a/ui/app/templates/components/database-connection.hbs +++ b/ui/app/templates/components/database-connection.hbs @@ -308,11 +308,13 @@ @message="This database type cannot be viewed in the UI. You will have to use the API or CLI to perform actions here." @bottomBorder={{true}} > - - - Go back - - Documentation + + {{else}} {{#each @model.showAttrs as |attr|}} diff --git a/ui/app/templates/components/generate-credentials-database.hbs b/ui/app/templates/components/generate-credentials-database.hbs index a40b257b920e..14c5b84dbc13 100644 --- a/ui/app/templates/components/generate-credentials-database.hbs +++ b/ui/app/templates/components/generate-credentials-database.hbs @@ -35,7 +35,7 @@ @iconPosition="trailing" @icon="docs-link" @text="Database documentation" - @href={{doc-link "/vault/docs/secrets/databases"}} + @href={{doc-link "/vault/api-docs/secret/databases"}} /> {{/unless}} diff --git a/ui/app/templates/components/identity/item-metadata.hbs b/ui/app/templates/components/identity/item-metadata.hbs index b119f8301474..6fe217e45968 100644 --- a/ui/app/templates/components/identity/item-metadata.hbs +++ b/ui/app/templates/components/identity/item-metadata.hbs @@ -24,16 +24,15 @@ {{else}} - - Edit - {{lowercase (humanize @model.identityType)}} - - - Learn more - + {{/each-in}} \ No newline at end of file diff --git a/ui/app/templates/components/keymgmt/provider-edit.hbs b/ui/app/templates/components/keymgmt/provider-edit.hbs index a8b84f04842c..20979b9b36bb 100644 --- a/ui/app/templates/components/keymgmt/provider-edit.hbs +++ b/ui/app/templates/components/keymgmt/provider-edit.hbs @@ -183,9 +183,12 @@ @title="No keys for this provider" @message="Keys for this provider will be listed here. Add a key to get started." > - - Create key - + {{/if}} {{/let}} diff --git a/ui/app/templates/vault/cluster/access/identity/aliases/index.hbs b/ui/app/templates/vault/cluster/access/identity/aliases/index.hbs index 3df1212e27cf..d3d2183d6821 100644 --- a/ui/app/templates/vault/cluster/access/identity/aliases/index.hbs +++ b/ui/app/templates/vault/cluster/access/identity/aliases/index.hbs @@ -51,14 +51,13 @@ @title="No {{this.identityType}} aliases yet" @message="A list of {{this.identityType}} aliases in this namespace will be listed here. Choose one of the {{pluralize this.identityType - }} and click "Create Alias" to get started." + }} and click "Add alias" to get started." > - - Create - {{this.identityType}} - - - Learn more - + {{/if}} \ No newline at end of file diff --git a/ui/app/templates/vault/cluster/access/identity/index.hbs b/ui/app/templates/vault/cluster/access/identity/index.hbs index 1191c2684c23..88cd07db0461 100644 --- a/ui/app/templates/vault/cluster/access/identity/index.hbs +++ b/ui/app/templates/vault/cluster/access/identity/index.hbs @@ -110,12 +110,6 @@ this.identityType }} in this namespace will be listed here. Create your first {{this.identityType}} to get started." > - - - Back to lookup - + {{else if (eq this.model.httpStatus 403)}} - - Back to lookup - + {{else}} {{#each this.model.errors as |error|}} diff --git a/ui/app/templates/vault/cluster/access/oidc/clients/client/providers.hbs b/ui/app/templates/vault/cluster/access/oidc/clients/client/providers.hbs index 5ec806895b55..6d66509073ef 100644 --- a/ui/app/templates/vault/cluster/access/oidc/clients/client/providers.hbs +++ b/ui/app/templates/vault/cluster/access/oidc/clients/client/providers.hbs @@ -11,8 +11,11 @@ @title="No available providers" @message="Edit an existing provider or create a new one to allow this application access for authentication requests." > - - View providers - + {{/if}} \ No newline at end of file diff --git a/ui/app/templates/vault/cluster/access/oidc/keys/key/clients.hbs b/ui/app/templates/vault/cluster/access/oidc/keys/key/clients.hbs index a2070c0da19c..cbd487067cda 100644 --- a/ui/app/templates/vault/cluster/access/oidc/keys/key/clients.hbs +++ b/ui/app/templates/vault/cluster/access/oidc/keys/key/clients.hbs @@ -12,8 +12,11 @@ @title="No applications allowed" @message="Access to this key has been limited, and no applications are allowed to use it. Edit the key to allow access." > - - Edit key - + {{/if}} \ No newline at end of file diff --git a/ui/app/templates/vault/cluster/access/oidc/providers/provider/clients.hbs b/ui/app/templates/vault/cluster/access/oidc/providers/provider/clients.hbs index 22dac8bb54e9..5eb3faeb5afa 100644 --- a/ui/app/templates/vault/cluster/access/oidc/providers/provider/clients.hbs +++ b/ui/app/templates/vault/cluster/access/oidc/providers/provider/clients.hbs @@ -12,8 +12,11 @@ @title="No applications allowed" @message="Access to this provider has been limited, and no applications are allowed to use it. Edit the provider to allow access." > - - Edit provider - + {{/if}} \ No newline at end of file diff --git a/ui/app/templates/vault/cluster/access/oidc/scopes/index.hbs b/ui/app/templates/vault/cluster/access/oidc/scopes/index.hbs index 26ea8878d24c..5642457be179 100644 --- a/ui/app/templates/vault/cluster/access/oidc/scopes/index.hbs +++ b/ui/app/templates/vault/cluster/access/oidc/scopes/index.hbs @@ -61,18 +61,16 @@ {{/each}} {{else}} - -
-

Use scope to define identity information about the authenticated user. - - Learn more. - -

-
- - Create scope - -
-
+ + {{/if}} \ No newline at end of file diff --git a/ui/app/templates/vault/cluster/access/reset-password-error.hbs b/ui/app/templates/vault/cluster/access/reset-password-error.hbs index 896cc62c0a05..1b5d785c887b 100644 --- a/ui/app/templates/vault/cluster/access/reset-password-error.hbs +++ b/ui/app/templates/vault/cluster/access/reset-password-error.hbs @@ -12,8 +12,10 @@ -

- Learn more - about updating passwords - here.

+
\ No newline at end of file diff --git a/ui/app/templates/vault/cluster/policies/index.hbs b/ui/app/templates/vault/cluster/policies/index.hbs index 15fe519bf0fb..7f477cb6bdf4 100644 --- a/ui/app/templates/vault/cluster/policies/index.hbs +++ b/ui/app/templates/vault/cluster/policies/index.hbs @@ -161,16 +161,21 @@ this.policyType }} policy to get started." > - - Create - {{uppercase this.policyType}} - policy - - - - Learn more - - + {{#if (eq this.policyType "acl")}} + + {{else}} + + {{/if}}
{{/if}} {{else}} diff --git a/ui/app/templates/vault/cluster/replication-dr-promote/details.hbs b/ui/app/templates/vault/cluster/replication-dr-promote/details.hbs index abe5e4b16df7..a98a37c8be19 100644 --- a/ui/app/templates/vault/cluster/replication-dr-promote/details.hbs +++ b/ui/app/templates/vault/cluster/replication-dr-promote/details.hbs @@ -15,16 +15,14 @@ @bottomBorder={{true}} class="is-shadowless" > - - - - + + {{else}} - - - - + + {{else}}
diff --git a/ui/app/templates/vault/cluster/secrets/backend/list.hbs b/ui/app/templates/vault/cluster/secrets/backend/list.hbs index f45435fe75dd..4d74b67951e2 100644 --- a/ui/app/templates/vault/cluster/secrets/backend/list.hbs +++ b/ui/app/templates/vault/cluster/secrets/backend/list.hbs @@ -108,32 +108,14 @@ {{else}} {{#if (eq this.baseKey.id "")}} {{#if (and options.firstStep (not this.tab))}} - - - {{options.create}} - - + {{else}} - - {{options.create}} - - + /> {{/if}} {{else}} {{#if this.filterIsFolder}} diff --git a/ui/app/templates/vault/cluster/secrets/backend/overview.hbs b/ui/app/templates/vault/cluster/secrets/backend/overview.hbs index 23456bba5a7c..55a93e5e02fc 100644 --- a/ui/app/templates/vault/cluster/secrets/backend/overview.hbs +++ b/ui/app/templates/vault/cluster/secrets/backend/overview.hbs @@ -16,15 +16,13 @@ {{#if (or this.model.connectionCapabilities.canCreate this.model.connectionCapabilities.canUpdate)}} - - Connect a database - + /> {{/if}} diff --git a/ui/app/templates/vault/cluster/unseal.hbs b/ui/app/templates/vault/cluster/unseal.hbs index d78fd5570a25..1aaaa2bac0a3 100644 --- a/ui/app/templates/vault/cluster/unseal.hbs +++ b/ui/app/templates/vault/cluster/unseal.hbs @@ -14,11 +14,12 @@ @bottomBorder={{true}} @message="Your Vault license has terminated and Vault is sealed. To unseal, add a current license to your configuration and restart Vault." > -

- - License documentation - -

+
diff --git a/ui/lib/core/addon/components/upgrade-page.hbs b/ui/lib/core/addon/components/upgrade-page.hbs index 9de302e5ef46..a0ddf5c5e68e 100644 --- a/ui/lib/core/addon/components/upgrade-page.hbs +++ b/ui/lib/core/addon/components/upgrade-page.hbs @@ -15,12 +15,11 @@ @title="Upgrade to use {{this.featureName}}" @message="You will need {{this.minimumEdition}} with {{this.featureName}} included to use this feature." > - - Vault Enterprise - - + /> \ No newline at end of file diff --git a/ui/lib/kmip/addon/templates/configuration.hbs b/ui/lib/kmip/addon/templates/configuration.hbs index 1e82c4d0bc54..ea41f8c22c18 100644 --- a/ui/lib/kmip/addon/templates/configuration.hbs +++ b/ui/lib/kmip/addon/templates/configuration.hbs @@ -30,9 +30,5 @@ - - Configure - - + /> {{/if}} \ No newline at end of file diff --git a/ui/lib/kubernetes/addon/components/config-cta.hbs b/ui/lib/kubernetes/addon/components/config-cta.hbs index 3dba2fa425f9..bed20e538f57 100644 --- a/ui/lib/kubernetes/addon/components/config-cta.hbs +++ b/ui/lib/kubernetes/addon/components/config-cta.hbs @@ -8,7 +8,5 @@ @title="Kubernetes not configured" @message="Get started by establishing the URL of the Kubernetes API to connect to, along with some additional options." > - - Configure Kubernetes - + \ No newline at end of file diff --git a/ui/lib/kubernetes/addon/components/page/roles.hbs b/ui/lib/kubernetes/addon/components/page/roles.hbs index 8dc8ffb47ed0..b4de50ed6c9a 100644 --- a/ui/lib/kubernetes/addon/components/page/roles.hbs +++ b/ui/lib/kubernetes/addon/components/page/roles.hbs @@ -26,11 +26,7 @@ data-test-config-cta @title="No roles yet" @message="When created, roles will be listed here. Create a role to start generating service account tokens." - > - - Create role - - + /> {{/if}} {{else}}
diff --git a/ui/lib/kv/addon/components/page/list.hbs b/ui/lib/kv/addon/components/page/list.hbs index a1635de1b273..ff9436c2f03a 100644 --- a/ui/lib/kv/addon/components/page/list.hbs +++ b/ui/lib/kv/addon/components/page/list.hbs @@ -134,17 +134,13 @@ /> {{else}} {{#if @filterValue}} - + {{else}} - - Create secret - - + /> {{/if}} {{/if}} {{/if}} \ No newline at end of file diff --git a/ui/lib/kv/addon/components/page/secret/details.hbs b/ui/lib/kv/addon/components/page/secret/details.hbs index bac1604191e3..e80da4c5a583 100644 --- a/ui/lib/kv/addon/components/page/secret/details.hbs +++ b/ui/lib/kv/addon/components/page/secret/details.hbs @@ -133,7 +133,12 @@ {{#if this.emptyState}} {{#if this.emptyState.link}} - Learn more + {{/if}} {{else}} diff --git a/ui/lib/kv/addon/components/page/secret/metadata/details.hbs b/ui/lib/kv/addon/components/page/secret/metadata/details.hbs index c34d8540a501..0c07e6c942c2 100644 --- a/ui/lib/kv/addon/components/page/secret/metadata/details.hbs +++ b/ui/lib/kv/addon/components/page/secret/metadata/details.hbs @@ -42,9 +42,13 @@ @message="This data is version-agnostic and is usually used to describe the secret being stored." > {{#if @secret.canUpdateMetadata}} - - Add metadata - + {{/if}} {{/each-in}} diff --git a/ui/lib/kv/addon/components/page/secret/metadata/edit.hbs b/ui/lib/kv/addon/components/page/secret/metadata/edit.hbs index 9d8bcb7b045a..0c0dc4147a59 100644 --- a/ui/lib/kv/addon/components/page/secret/metadata/edit.hbs +++ b/ui/lib/kv/addon/components/page/secret/metadata/edit.hbs @@ -51,9 +51,12 @@ @title="You do not have permissions to edit metadata" @message="Ask your administrator if you think you should have access." > - - View Metadata - - More here + + {{/if}} \ No newline at end of file diff --git a/ui/lib/ldap/addon/components/config-cta.hbs b/ui/lib/ldap/addon/components/config-cta.hbs index 2c5c176bdb10..19aa49323d1b 100644 --- a/ui/lib/ldap/addon/components/config-cta.hbs +++ b/ui/lib/ldap/addon/components/config-cta.hbs @@ -8,7 +8,5 @@ @title="LDAP not configured" @message="Get started by setting up the connection with your existing LDAP system." > - - Configure LDAP - + \ No newline at end of file diff --git a/ui/lib/ldap/addon/components/page/libraries.hbs b/ui/lib/ldap/addon/components/page/libraries.hbs index 6d644a49cc1e..0c0e372d6102 100644 --- a/ui/lib/ldap/addon/components/page/libraries.hbs +++ b/ui/lib/ldap/addon/components/page/libraries.hbs @@ -38,11 +38,7 @@ data-test-config-cta @title="No libraries created yet" @message="Use libraries to manage a set of highly privileged accounts that can be shared among a team." - > - - Create library - - + /> {{/if}} {{else}}
diff --git a/ui/lib/ldap/addon/components/page/roles.hbs b/ui/lib/ldap/addon/components/page/roles.hbs index 305dbfba15df..305902038cc1 100644 --- a/ui/lib/ldap/addon/components/page/roles.hbs +++ b/ui/lib/ldap/addon/components/page/roles.hbs @@ -38,11 +38,7 @@ data-test-config-cta @title="No roles created yet" @message="Roles in Vault will allow you to manage LDAP credentials. Create a role to get started." - > - - Create role - - + /> {{/if}} {{else}}
diff --git a/ui/lib/pki/addon/components/page/pki-issuer-list.hbs b/ui/lib/pki/addon/components/page/pki-issuer-list.hbs index 6942dacc1c8c..95ee744127df 100644 --- a/ui/lib/pki/addon/components/page/pki-issuer-list.hbs +++ b/ui/lib/pki/addon/components/page/pki-issuer-list.hbs @@ -108,9 +108,12 @@ <:empty> - - Configure PKI - + \ No newline at end of file diff --git a/ui/lib/pki/addon/components/page/pki-key-list.hbs b/ui/lib/pki/addon/components/page/pki-key-list.hbs index 3dbdcb8d401f..08131d0247ce 100644 --- a/ui/lib/pki/addon/components/page/pki-key-list.hbs +++ b/ui/lib/pki/addon/components/page/pki-key-list.hbs @@ -79,9 +79,12 @@ <:configure> - - Configure PKI - + \ No newline at end of file diff --git a/ui/lib/pki/addon/templates/certificates/index.hbs b/ui/lib/pki/addon/templates/certificates/index.hbs index 345240ae9cd6..f14b4bb12560 100644 --- a/ui/lib/pki/addon/templates/certificates/index.hbs +++ b/ui/lib/pki/addon/templates/certificates/index.hbs @@ -44,22 +44,19 @@ {{/each}} <:empty> - -
-

When created, certificates will be listed here. Select a role to start generating certificates.

-
- - View roles - -
-
-
+ <:configure> - - Configure PKI - + \ No newline at end of file diff --git a/ui/lib/pki/addon/templates/configuration/index.hbs b/ui/lib/pki/addon/templates/configuration/index.hbs index c2261e7a0350..d7200b3271e5 100644 --- a/ui/lib/pki/addon/templates/configuration/index.hbs +++ b/ui/lib/pki/addon/templates/configuration/index.hbs @@ -24,9 +24,12 @@ - - Configure PKI - + {{/if}} diff --git a/ui/lib/pki/addon/templates/overview.hbs b/ui/lib/pki/addon/templates/overview.hbs index ac6d3d18cc4b..7a898c7514cf 100644 --- a/ui/lib/pki/addon/templates/overview.hbs +++ b/ui/lib/pki/addon/templates/overview.hbs @@ -19,8 +19,11 @@ {{else}} - - Configure PKI - + {{/if}} \ No newline at end of file diff --git a/ui/lib/pki/addon/templates/roles/index.hbs b/ui/lib/pki/addon/templates/roles/index.hbs index c1c2f86f09dd..265a2c192f0d 100644 --- a/ui/lib/pki/addon/templates/roles/index.hbs +++ b/ui/lib/pki/addon/templates/roles/index.hbs @@ -50,22 +50,19 @@ {{/each}} <:empty> - -
-

When created, roles will be listed here. Create a role to start generating certificates.

-
- - Create role - -
-
-
+ <:configure> - - Configure PKI - + \ No newline at end of file diff --git a/ui/lib/pki/addon/templates/tidy/index.hbs b/ui/lib/pki/addon/templates/tidy/index.hbs index ba84950286d8..e974bc3d81eb 100644 --- a/ui/lib/pki/addon/templates/tidy/index.hbs +++ b/ui/lib/pki/addon/templates/tidy/index.hbs @@ -10,8 +10,11 @@ {{else}} - - Configure PKI - + {{/if}} \ No newline at end of file diff --git a/ui/lib/replication/addon/templates/mode/secondaries/index.hbs b/ui/lib/replication/addon/templates/mode/secondaries/index.hbs index b63f4c784905..d41be803a22e 100644 --- a/ui/lib/replication/addon/templates/mode/secondaries/index.hbs +++ b/ui/lib/replication/addon/templates/mode/secondaries/index.hbs @@ -68,14 +68,12 @@ @title="No known {{this.performanceMode}} secondary clusters associated with this cluster" @message="Associated secondary clusters will be listed here. Add your first secondary cluster to get started." > - {{#if this.model.canAddSecondary}} - - Add secondary - - {{/if}} - - Learn more - + {{/if}} {{/if}} \ No newline at end of file diff --git a/ui/lib/sync/addon/components/secrets/page/overview.hbs b/ui/lib/sync/addon/components/secrets/page/overview.hbs index ccb38629c493..1273e241a21e 100644 --- a/ui/lib/sync/addon/components/secrets/page/overview.hbs +++ b/ui/lib/sync/addon/components/secrets/page/overview.hbs @@ -48,9 +48,12 @@ @title="Error fetching information" @message="Ensure that the policy has access to read sync associations." > - - API reference - +
{{else}} diff --git a/ui/tests/acceptance/oidc-config/providers-scopes-test.js b/ui/tests/acceptance/oidc-config/providers-scopes-test.js index af06edc1a827..472fa443bc02 100644 --- a/ui/tests/acceptance/oidc-config/providers-scopes-test.js +++ b/ui/tests/acceptance/oidc-config/providers-scopes-test.js @@ -53,12 +53,12 @@ module('Acceptance | oidc-config providers and scopes', function (hooks) { assert .dom(SELECTORS.scopeEmptyState) .hasText( - `No scopes yet Use scope to define identity information about the authenticated user. Learn more. Create scope`, + `No scopes yet Use scope to define identity information about the authenticated user. OIDC provider scopes`, 'renders empty state no scopes are configured' ); assert - .dom(SELECTORS.scopeCreateButtonEmptyState) - .hasAttribute('href', '/ui/vault/access/oidc/scopes/create', 'empty state renders create scope link'); + .dom(SELECTORS.scopeCreateButton) + .hasAttribute('href', '/ui/vault/access/oidc/scopes/create', 'toolbar renders create scope link'); }); // LIST SCOPE EXIST diff --git a/ui/tests/acceptance/secrets/backend/database/secret-test.js b/ui/tests/acceptance/secrets/backend/database/secret-test.js index 2a42cfceb519..58cd3915cf5f 100644 --- a/ui/tests/acceptance/secrets/backend/database/secret-test.js +++ b/ui/tests/acceptance/secrets/backend/database/secret-test.js @@ -558,7 +558,7 @@ module('Acceptance | secrets/database/*', function (hooks) { assert.dom('[data-test-secret-list-tab="Roles"]').exists('renders connections tab'); await click('[data-test-secret-create="connections"]'); - assert.strictEqual(currentURL(), `/vault/secrets/${backend}/create`); + assert.strictEqual(currentURL(), `/vault/secrets/${backend}/create?itemType=connection`); // Login with restricted policy await logout.visit(); diff --git a/ui/tests/acceptance/secrets/backend/database/workflow-test.js b/ui/tests/acceptance/secrets/backend/database/workflow-test.js index 41c23dec5bfb..2266c2625ca9 100644 --- a/ui/tests/acceptance/secrets/backend/database/workflow-test.js +++ b/ui/tests/acceptance/secrets/backend/database/workflow-test.js @@ -99,7 +99,11 @@ module('Acceptance | database workflow', function (hooks) { await visit(`/vault/secrets/${this.backend}/overview`); assert.dom(PAGE.emptyStateTitle).hasText('Connect a database', 'empty state title is correct'); await click(PAGE.emptyStateAction); - assert.strictEqual(currentURL(), `/vault/secrets/${this.backend}/create`, 'Takes you to create page'); + assert.strictEqual( + currentURL(), + `/vault/secrets/${this.backend}/create?itemType=connection`, + 'Takes you to create page' + ); // fill in connection details await fillOutConnection(`connect-${this.backend}`); @@ -128,7 +132,11 @@ module('Acceptance | database workflow', function (hooks) { await visit(`/vault/secrets/${this.backend}/overview`); assert.dom(PAGE.emptyStateTitle).hasText('Connect a database', 'empty state title is correct'); await click(PAGE.emptyStateAction); - assert.strictEqual(currentURL(), `/vault/secrets/${this.backend}/create`, 'Takes you to create page'); + assert.strictEqual( + currentURL(), + `/vault/secrets/${this.backend}/create?itemType=connection`, + 'Takes you to create page' + ); // fill in connection details await fillOutConnection(`connect-${this.backend}`); @@ -158,7 +166,11 @@ module('Acceptance | database workflow', function (hooks) { await visit(`/vault/secrets/${this.backend}/overview`); assert.dom(PAGE.emptyStateTitle).hasText('Connect a database', 'empty state title is correct'); await click(PAGE.emptyStateAction); - assert.strictEqual(currentURL(), `/vault/secrets/${this.backend}/create`, 'Takes you to create page'); + assert.strictEqual( + currentURL(), + `/vault/secrets/${this.backend}/create?itemType=connection`, + 'Takes you to create page' + ); // fill in connection details await fillOutConnection(`bad-connection`); @@ -189,7 +201,11 @@ module('Acceptance | database workflow', function (hooks) { await visit(`/vault/secrets/${this.backend}/overview`); assert.dom(PAGE.emptyStateTitle).hasText('Connect a database', 'empty state title is correct'); await click(PAGE.emptyStateAction); - assert.strictEqual(currentURL(), `/vault/secrets/${this.backend}/create`, 'Takes you to create page'); + assert.strictEqual( + currentURL(), + `/vault/secrets/${this.backend}/create?itemType=connection`, + 'Takes you to create page' + ); // fill in connection details await fillOutConnection(`fail-rotate`); diff --git a/ui/tests/acceptance/secrets/backend/kv/kv-v2-workflow-navigation-test.js b/ui/tests/acceptance/secrets/backend/kv/kv-v2-workflow-navigation-test.js index b1369e35e1e4..015683faeca0 100644 --- a/ui/tests/acceptance/secrets/backend/kv/kv-v2-workflow-navigation-test.js +++ b/ui/tests/acceptance/secrets/backend/kv/kv-v2-workflow-navigation-test.js @@ -108,7 +108,7 @@ module('Acceptance | kv-v2 workflow | navigation', function (hooks) { return; }); test('empty backend - breadcrumbs, title, tabs, emptyState (a)', async function (assert) { - assert.expect(18); + assert.expect(15); const backend = this.emptyBackend; await navToBackend(backend); @@ -128,23 +128,8 @@ module('Acceptance | kv-v2 workflow | navigation', function (hooks) { assert.dom(PAGE.list.filter).doesNotExist('List filter does not show because no secrets exists.'); // Page content correct assert.dom(PAGE.emptyStateTitle).hasText('No secrets yet'); - assert.dom(PAGE.emptyStateActions).hasText('Create secret'); assert.dom(PAGE.list.createSecret).hasText('Create secret'); - // Click empty state CTA - await click(`${PAGE.emptyStateActions} a`); - assert.ok( - currentURL().startsWith(`/vault/secrets/${backend}/kv/create`), - `url includes /vault/secrets/${backend}/kv/create` - ); - - // Click cancel btn - await click(FORM.cancelBtn); - assert.ok( - currentURL().startsWith(`/vault/secrets/${backend}/kv/list`), - `url includes /vault/secrets/${backend}/kv/list` - ); - // click toolbar CTA await click(PAGE.list.createSecret); assert.ok( @@ -551,7 +536,7 @@ module('Acceptance | kv-v2 workflow | navigation', function (hooks) { return; }); test('empty backend - breadcrumbs, title, tabs, emptyState (dlr)', async function (assert) { - assert.expect(18); + assert.expect(15); const backend = this.emptyBackend; await navToBackend(backend); @@ -571,23 +556,8 @@ module('Acceptance | kv-v2 workflow | navigation', function (hooks) { assert.dom(PAGE.list.filter).doesNotExist('List filter does not show because no secrets exists.'); // Page content correct assert.dom(PAGE.emptyStateTitle).hasText('No secrets yet'); - assert.dom(PAGE.emptyStateActions).hasText('Create secret'); assert.dom(PAGE.list.createSecret).hasText('Create secret'); - // Click empty state CTA - await click(`${PAGE.emptyStateActions} a`); - assert.ok( - currentURL().startsWith(`/vault/secrets/${backend}/kv/create`), - `url includes /vault/secrets/${backend}/kv/create` - ); - - // Click cancel btn - await click(FORM.cancelBtn); - assert.ok( - currentURL().startsWith(`/vault/secrets/${backend}/kv/list`), - `url includes /vault/secrets/${backend}/kv/list` - ); - // click toolbar CTA await click(PAGE.list.createSecret); assert.ok( @@ -737,7 +707,7 @@ module('Acceptance | kv-v2 workflow | navigation', function (hooks) { return; }); test('empty backend - breadcrumbs, title, tabs, emptyState (mm)', async function (assert) { - assert.expect(18); + assert.expect(15); const backend = this.emptyBackend; await navToBackend(backend); @@ -757,23 +727,8 @@ module('Acceptance | kv-v2 workflow | navigation', function (hooks) { assert.dom(PAGE.list.filter).doesNotExist('List filter does not show because no secrets exists.'); // Page content correct assert.dom(PAGE.emptyStateTitle).hasText('No secrets yet'); - assert.dom(PAGE.emptyStateActions).hasText('Create secret'); assert.dom(PAGE.list.createSecret).hasText('Create secret'); - // Click empty state CTA - await click(`${PAGE.emptyStateActions} a`); - assert.ok( - currentURL().startsWith(`/vault/secrets/${backend}/kv/create`), - `url includes /vault/secrets/${backend}/kv/create` - ); - - // Click cancel btn - await click(FORM.cancelBtn); - assert.ok( - currentURL().startsWith(`/vault/secrets/${backend}/kv/list`), - `url includes /vault/secrets/${backend}/kv/list` - ); - // click toolbar CTA await click(PAGE.list.createSecret); assert.ok( diff --git a/ui/tests/helpers/oidc-config.js b/ui/tests/helpers/oidc-config.js index 670de3e4c93b..a226d8e1df8d 100644 --- a/ui/tests/helpers/oidc-config.js +++ b/ui/tests/helpers/oidc-config.js @@ -37,7 +37,6 @@ export const SELECTORS = { scopeEditButton: '[data-test-oidc-scope-edit]', scopeDetailsTab: '[data-test-oidc-scope-details]', scopeEmptyState: '[data-test-oidc-scope-empty-state]', - scopeCreateButtonEmptyState: '[data-test-oidc-scope-create-empty-state]', scopeCreateButton: '[data-test-oidc-scope-create]', // key route diff --git a/ui/tests/integration/components/kubernetes/page/roles-test.js b/ui/tests/integration/components/kubernetes/page/roles-test.js index 42e5d9420596..a1ce17a813f1 100644 --- a/ui/tests/integration/components/kubernetes/page/roles-test.js +++ b/ui/tests/integration/components/kubernetes/page/roles-test.js @@ -76,7 +76,6 @@ module('Integration | Component | kubernetes | Page::Roles', function (hooks) { 'When created, roles will be listed here. Create a role to start generating service account tokens.', 'Message renders' ); - assert.dom('[data-test-empty-state-actions] a').hasText('Create role', 'Action renders'); }); test('it should render no matches filter message', async function (assert) { diff --git a/ui/tests/integration/components/ldap/page/libraries-test.js b/ui/tests/integration/components/ldap/page/libraries-test.js index dea26f9fb61c..42c27c99af2f 100644 --- a/ui/tests/integration/components/ldap/page/libraries-test.js +++ b/ui/tests/integration/components/ldap/page/libraries-test.js @@ -87,7 +87,6 @@ module('Integration | Component | ldap | Page::Libraries', function (hooks) { 'Use libraries to manage a set of highly privileged accounts that can be shared among a team.', 'Message renders' ); - assert.dom('[data-test-empty-state-actions] a').hasText('Create library', 'Action renders'); }); test('it should render libraries list', async function (assert) { diff --git a/ui/tests/integration/components/ldap/page/roles-test.js b/ui/tests/integration/components/ldap/page/roles-test.js index ebe8b3ad74ef..97d293a2deac 100644 --- a/ui/tests/integration/components/ldap/page/roles-test.js +++ b/ui/tests/integration/components/ldap/page/roles-test.js @@ -89,7 +89,6 @@ module('Integration | Component | ldap | Page::Roles', function (hooks) { 'Roles in Vault will allow you to manage LDAP credentials. Create a role to get started.', 'Message renders' ); - assert.dom('[data-test-empty-state-actions] a').hasText('Create role', 'Action renders'); }); test('it should render roles list', async function (assert) {