From 1835a4868f47a2c51bfb2c3513788a2692bcbdc6 Mon Sep 17 00:00:00 2001 From: "clairebontempo@gmail.com" Date: Wed, 16 Aug 2023 19:56:57 -0700 Subject: [PATCH 1/2] remove default setting for max versions - leave unset with a value of 0 --- ui/app/models/secret-v2.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/app/models/secret-v2.js b/ui/app/models/secret-v2.js index 406ea4a5220e..4f273c40cb8b 100644 --- a/ui/app/models/secret-v2.js +++ b/ui/app/models/secret-v2.js @@ -35,7 +35,7 @@ export default SecretV2Model.extend(KeyMixin, { subText: 'An optional set of informational key-value pairs that will be stored with all secret versions.', }), maxVersions: attr('number', { - defaultValue: 10, + defaultValue: 0, label: 'Maximum number of versions', subText: 'The number of versions to keep per key. Once the number of keys exceeds the maximum number set here, the oldest version will be permanently deleted.', From 05af410dfa688c108e0d060d0449b499be3ebcd2 Mon Sep 17 00:00:00 2001 From: "clairebontempo@gmail.com" Date: Wed, 16 Aug 2023 20:57:37 -0700 Subject: [PATCH 2/2] add changelog --- changelog/22394.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changelog/22394.txt diff --git a/changelog/22394.txt b/changelog/22394.txt new file mode 100644 index 000000000000..4f5a2b9c89ff --- /dev/null +++ b/changelog/22394.txt @@ -0,0 +1,3 @@ +```release-note:bug +ui: fixes `max_versions` default for secret metadata unintentionally overriding kv engine defaults +``` \ No newline at end of file