Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Context to http requests #8134

Closed
arminm opened this issue Jan 10, 2020 · 1 comment · Fixed by #14388
Closed

Pass Context to http requests #8134

arminm opened this issue Jan 10, 2020 · 1 comment · Fixed by #14388
Labels
community-sentiment Tracking high-profile issues from the community core/api devex Developer Experience feature-request

Comments

@arminm
Copy link

arminm commented Jan 10, 2020

I'm having a hard time using APM with OpenTracing with this client, because there's no way for me to pass a context (e.g. HTTP requests' req.Context()) to the functions that make an HTTP call (i.e. the Logical module which does Read, ReadWithData, List, etc with HTTP calls to the backend).

I would like to ask for allowing for context to be passed to the Logical client's functions so people can do fine grained tracing, as well as cancel a Vault request if the original request has been cancelled or times out.

@ncabatoff ncabatoff added the devex Developer Experience label Jul 21, 2021
@iusergii
Copy link

Is anything changed since Opentracing support ?

@heatherezell heatherezell added the community-sentiment Tracking high-profile issues from the community label Jan 24, 2022
@heatherezell heatherezell linked a pull request Mar 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-sentiment Tracking high-profile issues from the community core/api devex Developer Experience feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants