Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine from the API if an Auth Backend is a plugin #7229

Closed
michaeljs1990 opened this issue Aug 1, 2019 · 2 comments
Closed

Determine from the API if an Auth Backend is a plugin #7229

michaeljs1990 opened this issue Aug 1, 2019 · 2 comments

Comments

@michaeljs1990
Copy link
Contributor

michaeljs1990 commented Aug 1, 2019

Is your feature request related to a problem? Please describe.
I am trying to add support so that terraforms vault provider can manage custom auth plugins. However the one way that I see to determine that has been removed and now returns nothing. It looks like before a none blank PluginName provided would have done the trick however now that always returns an empty string.

The reason this is important is because based on if this is a plugin or not the terraform state would need to be written differently since plugin path is required to enable the plugin. Additionally type plugin is required to be provided when enabling but when you list the auth backends it's type comes back out as "plugins-random-name".

Describe the solution you'd like
I don't much care what the solution is but it would be nice to be able to manage custom vault plugins in terraform. Right now I only care about the auth backend but this might apply more widely as well. Something like "IsPlugin: true/false" would be nice to return via the API.

Describe alternatives you've considered
Fork the code.

Does some other trick exist to determine when a auth method is a custom provided plugin that I am missing? This first came up in hashicorp/terraform-provider-vault#54.

@michaeljs1990
Copy link
Contributor Author

hrm, before anyone spends any time on this I found #5536. Taking a closer look but it looks like this isn't needed anymore but the docs needs to be updated a bit since they still reference plugin_name most places.

@michaeljs1990
Copy link
Contributor Author

The above issue does fix this. I'll open a PR to clean up the docs a bit so I don't feel like I wasted too much time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant