From 03d08aaaeb586f5abebe79dd80fb9fe3b233679d Mon Sep 17 00:00:00 2001
From: Chelsea Shaw <cshaw@hashicorp.com>
Date: Thu, 6 Jul 2023 14:11:47 -0500
Subject: [PATCH] allow download on all masked PKI values

---
 .../components/page/pki-certificate-details.hbs  |  1 +
 .../addon/components/page/pki-issuer-details.hbs |  1 +
 .../addon/components/page/pki-key-details.hbs    |  8 +++++++-
 ui/lib/pki/addon/components/pki-generate-csr.hbs |  8 +++++++-
 .../pki/addon/components/pki-generate-root.hbs   | 16 ++++++++++++++--
 .../pki/addon/components/pki-info-table-rows.hbs |  8 +++++++-
 .../components/pki-sign-intermediate-form.hbs    |  8 +++++++-
 7 files changed, 44 insertions(+), 6 deletions(-)

diff --git a/ui/lib/pki/addon/components/page/pki-certificate-details.hbs b/ui/lib/pki/addon/components/page/pki-certificate-details.hbs
index 4fb1d45c4046..bfc802749bb6 100644
--- a/ui/lib/pki/addon/components/page/pki-certificate-details.hbs
+++ b/ui/lib/pki/addon/components/page/pki-certificate-details.hbs
@@ -35,6 +35,7 @@
   {{#if field.options.masked}}
     <InfoTableRow @label={{or field.options.label (capitalize (humanize (dasherize field.name)))}}>
       <MaskedInput
+        @name={{field.name}}
         @value={{or (get @model field.name) null}}
         @displayOnly={{true}}
         @allowCopy={{true}}
diff --git a/ui/lib/pki/addon/components/page/pki-issuer-details.hbs b/ui/lib/pki/addon/components/page/pki-issuer-details.hbs
index bc8dddb4d9ac..1fc003e1b0d5 100644
--- a/ui/lib/pki/addon/components/page/pki-issuer-details.hbs
+++ b/ui/lib/pki/addon/components/page/pki-issuer-details.hbs
@@ -101,6 +101,7 @@
                 @value={{get @issuer attr.name}}
                 @displayOnly={{true}}
                 @allowCopy={{true}}
+                @allowDownload={{true}}
               />
             </InfoTableRow>
           {{else if (eq attr.name "keyId")}}
diff --git a/ui/lib/pki/addon/components/page/pki-key-details.hbs b/ui/lib/pki/addon/components/page/pki-key-details.hbs
index 09453bd4352e..7b89b475025f 100644
--- a/ui/lib/pki/addon/components/page/pki-key-details.hbs
+++ b/ui/lib/pki/addon/components/page/pki-key-details.hbs
@@ -49,7 +49,13 @@
   {{/each}}
   {{#if @key.privateKey}}
     <InfoTableRow @label="Private key">
-      <MaskedInput @value={{@key.privateKey}} @name="Private key" @displayOnly={{true}} @allowCopy={{true}} />
+      <MaskedInput
+        @name="Private key"
+        @value={{@key.privateKey}}
+        @displayOnly={{true}}
+        @allowCopy={{true}}
+        @allowDownload={{true}}
+      />
     </InfoTableRow>
   {{/if}}
 </div>
\ No newline at end of file
diff --git a/ui/lib/pki/addon/components/pki-generate-csr.hbs b/ui/lib/pki/addon/components/pki-generate-csr.hbs
index 751cb36e2908..8b8bc1684c59 100644
--- a/ui/lib/pki/addon/components/pki-generate-csr.hbs
+++ b/ui/lib/pki/addon/components/pki-generate-csr.hbs
@@ -22,7 +22,13 @@
               @addCopyButton={{eq attr.name "keyId"}}
             >
               {{#if (and attr.options.masked value)}}
-                <MaskedInput @value={{value}} @displayOnly={{true}} @allowCopy={{true}} />
+                <MaskedInput
+                  @name={{attr.name}}
+                  @value={{value}}
+                  @displayOnly={{true}}
+                  @allowCopy={{true}}
+                  @allowDownload={{true}}
+                />
               {{else if (eq attr.name "keyId")}}
                 <LinkTo @route="keys.key.details" @model={{@model.keyId}}>
                   {{@model.keyId}}
diff --git a/ui/lib/pki/addon/components/pki-generate-root.hbs b/ui/lib/pki/addon/components/pki-generate-root.hbs
index 01d7129b5647..b667bf5e128d 100644
--- a/ui/lib/pki/addon/components/pki-generate-root.hbs
+++ b/ui/lib/pki/addon/components/pki-generate-root.hbs
@@ -15,7 +15,13 @@
           <InfoTableRow
             @label={{capitalize (or attr.options.detailsLabel attr.options.label (humanize (dasherize attr.name)))}}
           >
-            <MaskedInput @value={{get @model attr.name}} @displayOnly={{true}} @allowCopy={{true}} />
+            <MaskedInput
+              @name={{attr.name}}
+              @value={{get @model attr.name}}
+              @displayOnly={{true}}
+              @allowCopy={{true}}
+              @allowDownload={{true}}
+            />
           </InfoTableRow>
         {{else}}
           <InfoTableRow
@@ -27,7 +33,13 @@
     {{/each}}
     <InfoTableRow @label="Private key">
       {{#if @model.privateKey}}
-        <MaskedInput @value={{@model.privateKey}} @displayOnly={{true}} @allowCopy={{true}} />
+        <MaskedInput
+          @name="privateKey"
+          @value={{@model.privateKey}}
+          @displayOnly={{true}}
+          @allowCopy={{true}}
+          @allowDownload={{true}}
+        />
       {{else}}
         <span class="tag">internal</span>
       {{/if}}
diff --git a/ui/lib/pki/addon/components/pki-info-table-rows.hbs b/ui/lib/pki/addon/components/pki-info-table-rows.hbs
index 5799ff3c773e..41863ae586d6 100644
--- a/ui/lib/pki/addon/components/pki-info-table-rows.hbs
+++ b/ui/lib/pki/addon/components/pki-info-table-rows.hbs
@@ -9,7 +9,13 @@
           @addCopyButton={{or (eq attr.name "issuerId") (eq attr.name "keyId")}}
         >
           {{#if (and attr.options.masked value)}}
-            <MaskedInput @value={{value}} @displayOnly={{true}} @allowCopy={{true}} />
+            <MaskedInput
+              @name={{attr.name}}
+              @value={{value}}
+              @displayOnly={{true}}
+              @allowCopy={{true}}
+              @allowDownload={{true}}
+            />
           {{else if attr.options.detailLinkTo}}
             <LinkTo @route={{attr.options.detailLinkTo}} @model={{value}}>{{value}}</LinkTo>
           {{else if (or (eq attr.name "privateKey") (eq attr.name "privateKeyType"))}}
diff --git a/ui/lib/pki/addon/components/pki-sign-intermediate-form.hbs b/ui/lib/pki/addon/components/pki-sign-intermediate-form.hbs
index 4e9184fca127..8c0269a7b1a9 100644
--- a/ui/lib/pki/addon/components/pki-sign-intermediate-form.hbs
+++ b/ui/lib/pki/addon/components/pki-sign-intermediate-form.hbs
@@ -13,7 +13,13 @@
         {{#let (find-by "name" fieldName @model.allFields) as |attr|}}
           <InfoTableRow @label={{or attr.options.label (humanize (dasherize attr.name))}} @value={{get @model attr.name}}>
             {{#if (and attr.options.masked (get @model attr.name))}}
-              <MaskedInput @value={{get @model attr.name}} @displayOnly={{true}} @allowCopy={{true}} />
+              <MaskedInput
+                @name={{attr.name}}
+                @value={{get @model attr.name}}
+                @displayOnly={{true}}
+                @allowCopy={{true}}
+                @allowDownload={{true}}
+              />
             {{else if (eq attr.name "serialNumber")}}
               <LinkTo
                 @route="certificates.certificate.details"