Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureAD/OIDC to support more than AD 200 groups #74

Closed
wrighbr opened this issue Sep 25, 2019 · 4 comments · Fixed by #120
Closed

AzureAD/OIDC to support more than AD 200 groups #74

wrighbr opened this issue Sep 25, 2019 · 4 comments · Fixed by #120

Comments

@wrighbr
Copy link

wrighbr commented Sep 25, 2019

Is your feature request related to a problem? Please describe.
There is a limitation within AAD and OIDC when a user is in more then 200 groups within Azure AD the groups claim will not be sent instead the below is sent

"_claim_names": {
    "groups": "src1"
  },
  "_claim_sources": {
    "src1": {
      "endpoint": "https://graph.windows.net/{TENANT_ID}/users/{USER-GUID}/getMemberObjects"
    }
  }

https://azure.microsoft.com/en-us/resources/samples/active-directory-dotnet-webapp-groupclaims/ see under Groups overage claim

Describe the solution you'd like
To have the _claim_sources supported by vault

@wrighbr wrighbr changed the title OIDC AzureAD groups claim to support when AD 200 groups AzureAD/OIDC to support more than AD 200 groups Sep 25, 2019
@kalafut
Copy link
Contributor

kalafut commented Sep 25, 2019

Interesting... so that’s why (per mailing list thread) one user was getting this unexpected _claim_sources.

@kalafut kalafut transferred this issue from hashicorp/vault Sep 25, 2019
@wrighbr
Copy link
Author

wrighbr commented Sep 25, 2019

Correct. This actually also includes nested jobs as well. So a user can be in part of 30 groups but the nested groups can add up to more than 200 groups.

@brondum
Copy link

brondum commented Oct 30, 2019

Exact same problem here when using Azure AD.

@sjobyt
Copy link

sjobyt commented Nov 5, 2019

Have the same problem. Need to get with the Azure AD admins to stop using nested groups... Would be great if Vault support integration for this.

More info distributed claims are supported by the openid standard not only specific to Azure AD.
https://openid.net/specs/openid-connect-core-1_0.html#AggregatedDistributedClaims

Foremast has this implemented with Go:
https://github.com/intuit/foremast/blob/master/foremast-barrelman/vendor/k8s.io/apiserver/plugin/pkg/authenticator/token/oidc/oidc.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants