Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper validation of role config #270

Open
hashidave opened this issue Jan 19, 2024 · 1 comment
Open

Improper validation of role config #270

hashidave opened this issue Jan 19, 2024 · 1 comment

Comments

@hashidave
Copy link

A customer of mine ran into an issue where they configured a jwt auth role using vault write config/auth/jwt/role/xyz and used the json in the screenshot. Vault took it with no complaints as shown.
There's a subtle error here in that claim_mapping should actually be claim_mappingS & it took us a while to track it down & wasted a bunch of time to figure out why the claim_mappings didn't work.
My ask is to at least warn on unknown parameters if not outright fail.
thanks.

image
image

@austingebauer
Copy link
Contributor

Hi @hashidave - Vault use to provide warnings for fields provided to the API that aren't a part of its field schema. It looks like this has since changed. It is now an opt-in parameter of specific backends via the TakesArbitraryInput field.

I remember there being mixed feedback when these warnings were added. How do people feel about them? Is it worth adding to this auth method? Or should it be addressed in a consistent way at the Vault level? Looking for thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants