Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add Default Security Group Resource #8861

Merged
merged 12 commits into from
Sep 15, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Sep 15, 2016

Part of #6093 , this PR adds a new resource aws_default_security_group for managing the Default Security Group.

  • each VPC has a default security group you cannot destroy (unless you destroy the VPC itself)
  • in EC2 Classic, each region has a default security group that you cannot destroy

Copy link
Member

@jbardin jbardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor whitespace issue is all I could find ;) 👍

cidr_blocks = ["10.0.0.0/8"]
}

tags {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some mixed tabs and spaces in the test HCL here and in the previous const.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@catsby catsby merged commit 79bb2e8 into master Sep 15, 2016
@catsby catsby deleted the f-aws-default-security-group branch September 15, 2016 18:59
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants