Add MemoryReservation To ECS Container Definition

[sharmaansh21]

Adds #8389

[sharmaansh21]

/cc @stack72

[stack72]

Hi @optimisticanshul

Thanks for the PR here - this isn't correct I'm afraid. This is a value that can be set by the user http://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#standard_container_definition_params

Paul

[sharmaansh21]

Sorry but i didn't get you, that's what it does if in definition
memoryReservation is set, this set value to that value.

container_definitions = <<DEFINITION
[
  {
    "cpu": 128,
    "environment": [{
      "name": "SECRET",
      "value": "KEY"
    }],
    "essential": true,
    "image": "mongo:latest",
    "memory": 128,
    "memoryReservation": 64,
    "name": "mongodb"
  }
]
DEFINITION
}

On 24-Aug-2016 13:48, "Paul Stack" [email protected] wrote:

Hi @optimisticanshul https://github.com/optimisticanshul

Thanks for the PR here - this isn't correct I'm afraid. This is a value
that can be set by the user http://docs.aws.amazon.com/AmazonECS/latest/
developerguide/task_definition_parameters.html#
standard_container_definition_params

Paul

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8437 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEViYcjBuXnFbCQmtZjxOjQFok9qJzUXks5qi_5agaJpZM4Jrrin
.

[stack72]

Hi @optimisticanshul

you haven't given the user any option to set the value via Terraform. You have made it computed: true which means that it is only set when a value comes back from the EC2 API

Paul

[sharmaansh21]

@stack72 sorry got it now. Thanks.

[stack72]

@optimisticanshul do you want me to take this PR over or are you in a situation of being able to work on it?

[sharmaansh21]

Hi Paul, sorry i am out till Saturday can't work on this atm.

On 25-Aug-2016 19:08, "Paul Stack" [email protected] wrote:

@optimisticanshul https://github.com/optimisticanshul do you want me to
take this PR over or are you in a situation of being able to work on it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8437 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEViYavRPHJwz7zNZPg7jsc2w1hEyqA7ks5qjZq8gaJpZM4Jrrin
.

[stack72]

Hi @optimisticanshul

I take that back - the work you have done here is correct :) I have renamed the variable to stick with our start naming convention. Other than that - I will be merging this shortly!

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcsDataSource_'                                            ✹
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/25 17:57:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsDataSource_ -timeout 120m
=== RUN   TestAccAWSEcsDataSource_ecsContainerDefinition
--- PASS: TestAccAWSEcsDataSource_ecsContainerDefinition (121.18s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    121.201s

Changes made in 0087068

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.