provider/aws: Set aws_alb security_groups computed #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @radeksimko |
| } | ||
| } | ||
|
|
||
| resource "aws_security_group" "alb_test" { |
There was a problem hiding this comment.
Is there any reason why not leave the aws_security_group out completely from this config?
There was a problem hiding this comment.
Yup good call, I'll go through and fix this up before merging.
|
Except that single nitpick this LGTM. ALB acceptance tests passing 👌 |
This commit fixes #8264 by making the security_groups attribute on aws_alb resources computed, allowing the default security group assigned by AWS to not generate perpetual plans forcing new resources.
kwilczynski
pushed a commit
to kwilczynski/terraform
that referenced
this pull request
Aug 18, 2016
This commit fixes hashicorp#8264 by making the security_groups attribute on aws_alb resources computed, allowing the default security group assigned by AWS to not generate perpetual plans forcing new resources.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #8264 by making the
security_groupsattribute onaws_albresources computed, allowing the default security group assigned by AWS to not generate perpetual plans forcing new resources.Part of #8137.