provider/aws: Fix aws_route53_record 0-2 migration #7907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @phinze |
When migrating the state of an `aws_route53_record`, a v0 state was never upgraded to v2, and a typo in a unit test masked this. This commit fixes the migration by chaining the invocation of the migration function, and corrects the test.
jen20
force-pushed
the
b-route53-record-migration
branch
from
021019f to
fa8160c
Compare
|
LGTM! Will merge when travis goes green |
kwilczynski
pushed a commit
to kwilczynski/terraform
that referenced
this pull request
Aug 4, 2016
When migrating the state of an `aws_route53_record`, a v0 state was never upgraded to v2, and a typo in a unit test masked this. This commit fixes the migration by chaining the invocation of the migration function, and corrects the test.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating the state of an
aws_route53_record, a v0 state was never upgraded to v2, and a typo in a unit test masked this. This commit fixes the migration by chaining the invocation of the migration function, and corrects the test.