provider/aws: Defensively code around db_security_group ingress rules
#7893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7812 All of the options of `aws_db_security_group` ingress rules are optional. Therefore, when one of them isn't set (and AWS doesn't calculate the value), Terraform threw a panic This commit just defensively codes around this fact. It checks to make sure there is a value returned from the API before adding it to the map ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBSecurityGroup_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBSecurityGroup_ -timeout 120m === RUN TestAccAWSDBSecurityGroup_basic --- PASS: TestAccAWSDBSecurityGroup_basic (38.66s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 38.682s ```
|
LGTM |
kwilczynski
pushed a commit
to kwilczynski/terraform
that referenced
this pull request
Aug 18, 2016
…es (hashicorp#7893) Fixes hashicorp#7812 All of the options of `aws_db_security_group` ingress rules are optional. Therefore, when one of them isn't set (and AWS doesn't calculate the value), Terraform threw a panic This commit just defensively codes around this fact. It checks to make sure there is a value returned from the API before adding it to the map ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBSecurityGroup_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBSecurityGroup_ -timeout 120m === RUN TestAccAWSDBSecurityGroup_basic --- PASS: TestAccAWSDBSecurityGroup_basic (38.66s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 38.682s ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7812
All of the options of
aws_db_security_groupingress rules areoptional. Therefore, when one of them isn't set (and AWS doesn't
calculate the value), Terraform threw a panic
This commit just defensively codes around this fact. It checks to make
sure there is a value returned from the API before adding it to the map