Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Support task_role_arn on aws_ecs_task_definition #7653

Merged
merged 1 commit into from
Jul 20, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 14, 2016

Fixes #7633

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_'                         ✹
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsTaskDefinition_ -timeout 120m
=== RUN   TestAccAWSEcsTaskDefinition_basic
--- PASS: TestAccAWSEcsTaskDefinition_basic (34.09s)
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (18.32s)
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (146.41s)
=== RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (21.85s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    220.699s

@stack72 stack72 force-pushed the ecs-rolearn branch 2 times, most recently from 5ee1987 to 79dced4 Compare July 15, 2016 16:09
@stack72 stack72 changed the title [WIP] provider/aws: Support task_role_arn on aws_ecs_task_definition provider/aws: Support task_role_arn on aws_ecs_task_definition Jul 15, 2016
@catsby
Copy link
Contributor

catsby commented Jul 20, 2016

LGTM

@stack72 stack72 merged commit 0edf830 into master Jul 20, 2016
@stack72 stack72 deleted the ecs-rolearn branch September 3, 2016 17:28
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for aws_ecs_task_definition to have task_role_arn
2 participants