aws/route53_zone: Make delegation_set_id conflict w/ vpc_id

[radeksimko]

• as per the API reference it is not possible to use delegation sets w/ private hosted zones
  • http://docs.aws.amazon.com/Route53/latest/APIReference/API-create-hosted-zone-private.html
  • http://docs.aws.amazon.com/Route53/latest/APIReference/API_CreateHostedZone.html
• if you specify both AWS returns confusing error "InvalidInput" with no further details so this should reduce potential confusions & improve UX

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSRoute53Zone'

TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSRoute53Zone -timeout 120m
=== RUN   TestAccAWSRoute53Zone_importBasic
--- PASS: TestAccAWSRoute53Zone_importBasic (46.12s)
=== RUN   TestAccAWSRoute53ZoneAssociation_basic
--- PASS: TestAccAWSRoute53ZoneAssociation_basic (104.08s)
=== RUN   TestAccAWSRoute53ZoneAssociation_region
--- PASS: TestAccAWSRoute53ZoneAssociation_region (110.52s)
=== RUN   TestAccAWSRoute53Zone_basic
--- PASS: TestAccAWSRoute53Zone_basic (49.00s)
=== RUN   TestAccAWSRoute53Zone_updateComment
--- PASS: TestAccAWSRoute53Zone_updateComment (57.39s)
=== RUN   TestAccAWSRoute53Zone_private_basic
--- PASS: TestAccAWSRoute53Zone_private_basic (66.48s)
=== RUN   TestAccAWSRoute53Zone_private_region
--- PASS: TestAccAWSRoute53Zone_private_region (69.22s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    502.842s

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSRoute53DelegationSet'

TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSRoute53DelegationSet -timeout 120m
=== RUN   TestAccAWSRoute53DelegationSet_importBasic
--- PASS: TestAccAWSRoute53DelegationSet_importBasic (26.67s)
=== RUN   TestAccAWSRoute53DelegationSet_basic
--- PASS: TestAccAWSRoute53DelegationSet_basic (11.65s)
=== RUN   TestAccAWSRoute53DelegationSet_withZones
--- PASS: TestAccAWSRoute53DelegationSet_withZones (51.45s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    89.806s

[jen20]

LGTM pending travis! Thanks @radeksimko!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.