Add name_prefix to aws_iam_instance_profile and aws_iam_role

[joshuaspence]

Ref #6099. Add a name_prefix attribute to the aws_iam_instance_profile and aws_iam_role resources.

[stack72]

Hi @joshuaspence

when you said that it doesn't quite work yet, what do you mean? :)

P;

[joshuaspence]

Oh, the acceptance tests are failing and I don't understand why.

[stack72]

@joshuaspence as you do not specify a name but do specify a name_prefix, you need to make name Computed. This means that when we set it in the Read, we will not get any alternative plan

Doing this locally gave me this:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSIAMInstanceProfile'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSIAMInstanceProfile -timeout 120m
=== RUN   TestAccAWSIAMInstanceProfile_basic
--- PASS: TestAccAWSIAMInstanceProfile_basic (16.34s)
=== RUN   TestAccAWSIAMInstanceProfile_namePrefix
--- PASS: TestAccAWSIAMInstanceProfile_namePrefix (17.01s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    33.367s

[stack72]

@joshuaspence ok, 2 small changes needed here and we are in a working situation :)

P.

[joshuaspence]

Thanks, this should be ready to go now. I didn't quite understand why the name field needs to be marked as computed because it may not necessarily be so (for example, if the name attribute of the prefix is specified rather than name_prefix).

[joshuaspence]

This value probably isn't correct... are there any guarantees made about the length of the string returned by the uuidV4 function?

[stack72]

Hi @joshuaspence

I'll give this a final set of tests when I am back online. Just a note on Computed - this is used when there is a chance that the value get's set on the Read but not in the initial config. The Computed means that Terraform will understand why there would be changes in that case

P.

[stack72]

@joshuaspence these looks great now :)

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRole'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRole -timeout 120m
=== RUN   TestAccAWSRolePolicyAttachment_basic
--- PASS: TestAccAWSRolePolicyAttachment_basic (33.34s)
=== RUN   TestAccAWSRole_basic
--- PASS: TestAccAWSRole_basic (16.32s)
=== RUN   TestAccAWSRole_namePrefix
--- PASS: TestAccAWSRole_namePrefix (16.08s)
=== RUN   TestAccAWSRole_testNameChange
--- PASS: TestAccAWSRole_testNameChange (39.93s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    105.703s

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSIAMInstanceProfile'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSIAMInstanceProfile -timeout 120m
=== RUN   TestAccAWSIAMInstanceProfile_basic
--- PASS: TestAccAWSIAMInstanceProfile_basic (18.32s)
=== RUN   TestAccAWSIAMInstanceProfile_namePrefix
--- PASS: TestAccAWSIAMInstanceProfile_namePrefix (19.99s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    38.329s

Thanks for the hard work!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.