provider/aws: Mark Lambda function as gone when it's gone

[radeksimko]

Replaces #5205

Patches we discussed in that linked PR are implemented + functionality verified (and verifiable by anyone else) manually via applying https://gist.github.com/radeksimko/e81daddbde9c5aec0fdf3886231a2922 then running

aws lambda remove-permission --function-name lambda_function_name --statement-id AllowExecutionFromSNS

and then

terraform refresh

cc @Bowbaq

[stack72]

Hey @radeksimko

Just been able to test this out and it LGTM! Also ran the acceptance tests and they pass as expected:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLambdaPermission'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLambdaPermission -timeout 120m
=== RUN   TestAccAWSLambdaPermission_basic
--- PASS: TestAccAWSLambdaPermission_basic (39.58s)
=== RUN   TestAccAWSLambdaPermission_withRawFunctionName
--- PASS: TestAccAWSLambdaPermission_withRawFunctionName (38.56s)
=== RUN   TestAccAWSLambdaPermission_withQualifier
--- PASS: TestAccAWSLambdaPermission_withQualifier (42.61s)
=== RUN   TestAccAWSLambdaPermission_multiplePerms
--- PASS: TestAccAWSLambdaPermission_multiplePerms (80.85s)
=== RUN   TestAccAWSLambdaPermission_withS3
--- PASS: TestAccAWSLambdaPermission_withS3 (57.98s)
=== RUN   TestAccAWSLambdaPermission_withSNS
--- PASS: TestAccAWSLambdaPermission_withSNS (39.82s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    299.415s

Nice work :)

P.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.