provider/aws: fixing the aws_internet_gateway resource #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource is build so it can attach and detach the Internet Gateway from a VPC, but as the schema has `Required` and `ForceNew` both set to `true` for the vpc_id field it will never use these capabilities.
svanharmelen
pushed a commit
that referenced
this pull request
Dec 14, 2014
…ateway provider/aws: fixing the aws_internet_gateway resource
|
Nice, this logic looks correct to me. Thanks |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource is build so it can attach and detach the Internet Gateway from a VPC, but as the schema has
RequiredandForceNewboth set totruefor the vpc_id field it will never use these capabilities the way they are meant to..The tests didn't change, but if you run the tests without this PR you'll notice a new Internet Gateway is created. With this PR that no longer happens so all features of this resource are now being used properly.