provider/google: Support static private IP addresses

[evandbrown]

The private address of an instance's network interface may now be specified.
If no value is provided, an address will be chosen by Google Compute Engine
and that value will be read into Terraform state.

[imkira]

Can we expect this to be merged by v0.7?

[stack72]

Hey @evandbrown

Any chance you could rebase this on master? I have ran the tests and they look good :)

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeInstance_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeInstance_ -timeout 120m
=== RUN   TestAccComputeInstance_basic_deprecated_network
--- PASS: TestAccComputeInstance_basic_deprecated_network (99.65s)
=== RUN   TestAccComputeInstance_basic1
--- PASS: TestAccComputeInstance_basic1 (78.67s)
=== RUN   TestAccComputeInstance_basic2
--- PASS: TestAccComputeInstance_basic2 (76.52s)
=== RUN   TestAccComputeInstance_basic3
--- PASS: TestAccComputeInstance_basic3 (76.58s)
=== RUN   TestAccComputeInstance_IP
--- PASS: TestAccComputeInstance_IP (105.40s)
=== RUN   TestAccComputeInstance_disksWithoutAutodelete
--- PASS: TestAccComputeInstance_disksWithoutAutodelete (118.97s)
=== RUN   TestAccComputeInstance_disksWithAutodelete
--- PASS: TestAccComputeInstance_disksWithAutodelete (96.48s)
=== RUN   TestAccComputeInstance_local_ssd
--- PASS: TestAccComputeInstance_local_ssd (91.77s)
=== RUN   TestAccComputeInstance_update_deprecated_network
--- PASS: TestAccComputeInstance_update_deprecated_network (131.60s)
=== RUN   TestAccComputeInstance_forceNewAndChangeMetadata
--- PASS: TestAccComputeInstance_forceNewAndChangeMetadata (183.93s)
=== RUN   TestAccComputeInstance_update
--- PASS: TestAccComputeInstance_update (133.17s)
=== RUN   TestAccComputeInstance_service_account
--- PASS: TestAccComputeInstance_service_account (91.23s)
=== RUN   TestAccComputeInstance_scheduling
--- PASS: TestAccComputeInstance_scheduling (87.56s)
=== RUN   TestAccComputeInstance_subnet_auto
--- PASS: TestAccComputeInstance_subnet_auto (180.37s)
=== RUN   TestAccComputeInstance_subnet_custom
--- PASS: TestAccComputeInstance_subnet_custom (137.72s)
=== RUN   TestAccComputeInstance_address_auto
--- PASS: TestAccComputeInstance_address_auto (151.53s)
=== RUN   TestAccComputeInstance_address_custom
--- PASS: TestAccComputeInstance_address_custom (152.04s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 1993.218s

Does this need a docs update?

Thanks

Paul

[evandbrown]

@stack72 rebased, and d'oh on the missing docs. That's there now. Thanks!

[stack72]

@evandbrown thanks :) LGTM now

P

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.