provider/aws: Added migration for tier attribute in aws_elastic_beanstalk_environment resource.

[dharrisio]

Adds migration for tier attribute. For #6164.

=== RUN   TestAWSElasticBeanstalkEnvironmentMigrateState
2016/04/13 14:17:09 [INFO] Found AWS Elastic Beanstalk Environment State v0; migrating to v1
2016/04/13 14:17:09 [DEBUG] Attributes before migration: map[string]string{"tier":""}
2016/04/13 14:17:09 [DEBUG] Attributes after migration: map[string]string{"tier":"WebServer"}
2016/04/13 14:17:09 [INFO] Found AWS Elastic Beanstalk Environment State v0; migrating to v1
2016/04/13 14:17:09 [DEBUG] Attributes before migration: map[string]string{"tier":"WebServer"}
2016/04/13 14:17:09 [DEBUG] Attributes after migration: map[string]string{"tier":"WebServer"}
2016/04/13 14:17:09 [INFO] Found AWS Elastic Beanstalk Environment State v0; migrating to v1
2016/04/13 14:17:09 [DEBUG] Attributes before migration: map[string]string{"tier":"Worker"}
2016/04/13 14:17:09 [DEBUG] Attributes after migration: map[string]string{"tier":"Worker"}
--- PASS: TestAWSElasticBeanstalkEnvironmentMigrateState (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    0.006s

I also tested this with the tf document and older Terraform version from #6164

[dharrisio]

Hey @stack72, I was wondering if you had a chance to look this over yet. I assume this one would probably be good to merge before the next release to avoid state errors. Just wanted to make sure it's still on the radar.

Thanks!

[stack72]

Hi @dharrisio

apologies for not getting back to this sooner. In theory, this is all good. I just need to get someone from the core team to check it out as I know nothing about migrating state. I will ask @catsby, @phinze or @jen20 to bless this for me to merge :)

P.

[jen20]

LGTM if acceptance tests pass!

[stack72]

Tests look good :) Thanks for following up with this PR @dharrisio

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSBeanstalkEnv' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSBeanstalkEnv -timeout 120m
=== RUN   TestAccAWSBeanstalkEnv_basic
--- PASS: TestAccAWSBeanstalkEnv_basic (374.67s)
=== RUN   TestAccAWSBeanstalkEnv_tier
--- PASS: TestAccAWSBeanstalkEnv_tier (582.58s)
=== RUN   TestAccAWSBeanstalkEnv_outputs
--- PASS: TestAccAWSBeanstalkEnv_outputs (347.64s)
=== RUN   TestAccAWSBeanstalkEnv_cname_prefix
--- PASS: TestAccAWSBeanstalkEnv_cname_prefix (349.73s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    1654.628s

[dharrisio]

Thanks @stack72 and @jen20!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.