Added support for the encryption flag on ebs_block_devices in launch configurations

[ElliotG]

The aws-sdk supports setting an encrypted flag on ebs_block_devices in launch configurations. If no snapshot is specified, then the encryption flag can be turned on/off. Default is off. Tested this by creating launch configurations with this both on and off.

[jen20]

Hi @ElliotG! Thanks for submitting this - my initial impression is that this looks good. Is there any chance you have time to codify the behaviour in an acceptance test? If not we will likely still be able to merge this, but something like encrypted volumes feels like it should have some test coverage to me!

[ElliotG]

Sure. I'll try to get to this in the next week. Thanks for reviewing!

-Elliot Graebert
Cell: (408) 410-5407

On Jan 4, 2016, at 12:22 PM, James Nugent [email protected] wrote:

Hi @ElliotG! Thanks for submitting this - my initial impression is that this looks good. Is there any chance you have time to codify the behaviour in an acceptance test? If not we will likely still be able to merge this, but something like encrypted volumes feels like it should have some test coverage to me!

—
Reply to this email directly or view it on GitHub.

[catsby]

Fixes #3792

[ElliotG]

Hey folks,

Not sure if I'm supposed to respond to acknowledge that I've added a test? I know this is a minor feature, but this would enable me to start using mainline Terraform again :)

[catsby]

Looks good @ElliotG thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.