-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/google: read credentials as contents instead of path #3901
Conversation
@sparkprime @lwander this seem okay to you? (We'll maintain the deprecated behavior for a good while to ensure it doesn't break anybody's existing config.) |
9aa0b54
to
03d8a88
Compare
Building on the work in #3846, shifting the Google provider's configuration option from `account_file` to `credentials`.
03d8a88
to
eb9a938
Compare
LGTM Tangentially related: now that we support default credentials (meaning the account file is optional), Terraform will still prompt me to provide an account file when I purposefully don't while running |
LGTM Lars: You can use "" though I think? It would be nice if we could omit it altogether though. |
@lwander Terraform shouldn't be prompting for optional variables - if you can snag an example of this occurring you can file it as a bug. 🐛 👍 |
Thanks for the review! Landing. |
provider/google: read credentials as contents instead of path
…istener-update-certificatenotfound resource/aws_lb_listener: Retry CertificateNotFound errors on update for IAM eventual consistency
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Building on the work in #3846, shifting the Google provider's
configuration option from
account_file
tocredentials
.