provider/aws: add name_prefix option to launch config #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See hashicorp#2911. This adds a `name_prefix` option to `aws_launch_configuration` resources. When specified, it is used instead of `terraform-` as the prefix for the launch configuration. It conflicts with `name`, so existing functionality is unchanged. `name` still sets the name explicitly. Added an acceptance test, and updated the site documentation.
pforman
changed the title
|
+1 |
|
Looks good to me, thanks! |
catsby
added a commit
that referenced
this pull request
Nov 10, 2015
provider/aws: add name_prefix option to launch config
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #2911.
This adds a
name_prefixoption toaws_launch_configurationresources, making thecreate_before_destroylifecycle pattern a bit more understandable in large configs.When specified,
name_prefixis used instead of "terraform-" as the prefix for the launch configuration name, with the 26-character uuid appended. It's set to Conflict withname, so existing functionality is unchanged.namestill sets the name explicitly.Added an acceptance test, and updated the site documentation.
Let me know if there's anything out of place or that you'd like to change.
Thanks!