Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewStringList with an empty slice creates a list containing a single empty string #3437

Closed
svend opened this issue Oct 7, 2015 · 2 comments

Comments

@svend
Copy link
Contributor

svend commented Oct 7, 2015

Calling NewStringList with an empty slice creates a non-empty list (containing a single emtpy string). This means an empty list cannot be represented using StringList.

There are tests showing the behavior here:

svend@882ef6e

--- FAIL: TestStringList_empty_slice (0.00s)
    string_list_test.go:37: Expected [], got [""]
--- FAIL: TestStringList_empty_slice_length (0.00s)
    string_list_test.go:50: Expected length of [] to be 0, got 1
FAIL
@svend
Copy link
Contributor Author

svend commented Oct 24, 2015

This was fixed by #3239

@svend svend closed this as completed Oct 24, 2015
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants