ModuleSourceRemote String now considers query string (#31250)

[fatahfattah]

This fixes an issue in the String() for ModuleSourceRemote in which it does not consider query strings (if present). Before this fix, any subdirectory would simply be appended to the ModuleSourceRemote.Package instead of inserting it between the root package and any query parameters.

Related: #31250

[hashicorp-cla]

All committers have signed the CLA.

[crw]

Thanks for this submission. Although I cannot commit to having this PR reviewed at this time, we acknowledge your contribution and appreciate it!

[crw]

Hi @fatahfattah, if you could please write one or more tests for this change (even simple tests will be fine), we can get this reviewed. Thanks again for your submission!

[fatahfattah]

Hi @crw I added a few tests, please let me know if they are okay or if you require some changes. I noticed there was no separate testing suite for parsing the ModuleSourceRemote so I added that as well.

[crw]

The team member who is going to review this is on vacation, but we'll make sure to review this as soon as he is back. Thanks!

[apparentlymart]

Thanks for working on this @fatahfattah!

This implementation looks good to me, and so I'm going to merge it now.

[github-actions]

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.