Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project parameter to more Cloudstack resources #3035

Merged
merged 3 commits into from
Aug 21, 2015
Merged

Add project parameter to more Cloudstack resources #3035

merged 3 commits into from
Aug 21, 2015

Conversation

hany
Copy link
Contributor

@hany hany commented Aug 20, 2015

With some Cloudstack implementations, the projectid query parameter is required to be passed to most API calls. It appears the underlying xanzy/go-cloudstack library has support for this. This PR adds this parameters to the following Cloudstack resources:

  • cloudstack_vpc
  • cloudstack_network
  • cloudstack_ip

It's possible that more resources will require this parameter, but I haven't come across those situations yet.

@hany
Copy link
Contributor Author

hany commented Aug 20, 2015

Closes #3010

@svanharmelen
Copy link
Contributor

@hany thanks for the PR! I've planned to work a day on TF again tomorrow, so will check and merge (if all is good) before the weekend 😃

@hany
Copy link
Contributor Author

hany commented Aug 20, 2015

Thanks @svanharmelen! I've just added the parameter to cloudstack_disk. Since the provider we're utilizing requires projectid to be passed every time to all calls, would it make sense to add this further up, perhaps at the provider itself?

@svanharmelen
Copy link
Contributor

would it make sense to add this further up, perhaps at the provider itself?

Not sure if that would be the appropriate location, but I understand that it would be helpful to not having to configure this in all resources again and again.

For now I would suggest using a Terraform variable which you define once (maybe based on a environment variable) and copy paste that in all locations where you need it.

As for this PR... LGTM! So I'll go ahead and merge it....

svanharmelen pushed a commit that referenced this pull request Aug 21, 2015
Add project parameter to more Cloudstack resources
@svanharmelen svanharmelen merged commit 23c1dba into hashicorp:master Aug 21, 2015
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants