Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix ECS cluster+service bugs #2698

Merged

Conversation

radeksimko
Copy link
Member

Since these bugs were more or less related to each other and the SDK has changed a little bit too, it would be more difficult to send these as separate PRs.
At least I tried to separate modifications per commits, so it should be easy to review.

Closes:

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=Ecs'
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=Ecs -timeout 90m
=== RUN TestAccAWSEcsCluster_basic
--- PASS: TestAccAWSEcsCluster_basic (2.40s)
=== RUN TestAccAWSEcsServiceWithARN
--- PASS: TestAccAWSEcsServiceWithARN (14.66s)
=== RUN TestAccAWSEcsServiceWithFamilyAndRevision
--- PASS: TestAccAWSEcsServiceWithFamilyAndRevision (20.99s)
=== RUN TestAccAWSEcsServiceWithRenamedCluster
--- PASS: TestAccAWSEcsServiceWithRenamedCluster (38.28s)
=== RUN TestAccAWSEcsTaskDefinition_basic
--- PASS: TestAccAWSEcsTaskDefinition_basic (3.08s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    79.429s

@radeksimko radeksimko changed the title Fix ECS cluster+service bugs provider/aws: Fix ECS cluster+service bugs Jul 12, 2015
@phinze
Copy link
Contributor

phinze commented Jul 14, 2015

LGTM

radeksimko added a commit that referenced this pull request Jul 14, 2015
provider/aws: Fix ECS cluster+service bugs
@radeksimko radeksimko merged commit 763ed0f into hashicorp:master Jul 14, 2015
@radeksimko radeksimko deleted the b-aws-ecs-cluster-destroy branch July 14, 2015 17:03
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants