Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communicator/ssh: print ssh bastion host details to output #2684

Merged
merged 1 commit into from
Jul 16, 2015

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Jul 10, 2015

No description provided.

"Using configured bastion host..."+
" Host: %s\n"+
" User: %s\n"+
" Password: %t\n"+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought Terraform user output (w/out TF_LOG=1) was always treated as output without secrets (based on the fact that Terraform doesn't print out used AWS credentials, even though it would be quite helpful for debugging sometimes), but maybe I'm just wrong and it's ok to print passwords out? I just see that being a potential issue during public demos 😃 and generally when storing these logs anywhere in unsecured log storage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the password and private key outputs here are just booleans. So you are correct! 😀

phinze added a commit that referenced this pull request Jul 16, 2015
communicator/ssh: print ssh bastion host details to output
@phinze phinze merged commit 98891ae into master Jul 16, 2015
@phinze phinze deleted the f-print-bastion-host-details branch July 16, 2015 17:13
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants