Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow evaluation of 0 instances during apply #26264

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Sep 16, 2020

While this was easier to spot during plan, it is also possible to
evaluate resources with 0 instances during apply as well.

This doesn't effect the failure when scaling CBD instances, it only
changes the fact that the inconsistent value is no longer unknown.

Fixes #26252

@jbardin jbardin requested a review from a team September 16, 2020 14:58
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #26264 into master will not change coverage.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
terraform/evaluate.go 52.74% <100.00%> (+0.21%) ⬆️
communicator/communicator.go 79.62% <0.00%> (-3.71%) ⬇️
backend/remote/backend_common.go 54.57% <0.00%> (-0.68%) ⬇️
dag/marshal.go 54.44% <0.00%> (+1.11%) ⬆️
terraform/node_resource_plan.go 93.44% <0.00%> (+1.63%) ⬆️

While this was easier to spot during plan, it is also possible to
evaluate resources with 0 instances during apply as well.

This doesn't effect the failure when scaling CBD instances, it only
changes the fact that the inconsistent value is no longer unknown.
@jbardin jbardin merged commit 696290e into master Sep 16, 2020
@jbardin jbardin deleted the jbardin/evaluate-destroy branch September 16, 2020 15:35
jbardin added a commit that referenced this pull request Sep 16, 2020
@ghost
Copy link

ghost commented Oct 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"inconsistent final plan" when conditionally removing a referenced resource
2 participants