Fix bug for force push for backends besides the remote backend #26190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pselle
commented
Sep 9, 2020
pselle
commented
Sep 9, 2020
states/remote/state_test.go
Outdated
| @@ -302,6 +302,168 @@ func TestWriteStateForMigration(t *testing.T) { | |||
| }, | |||
| } | |||
|
|
|||
| testCases := []migrationTestCase{ | |||
There was a problem hiding this comment.
The diff implies this is the new section, however, it is the previous set of test cases with the EnableForcePush-specific code removed. The test TestWriteStateForMigrationWithForcePushClient is the new test.
Codecov Report
|
pselle
force-pushed
the
pselle/force-push-fix
branch
from
2cbcafb
to
9d90bd6
Compare
alisdair
approved these changes
Sep 9, 2020
In refactoring the force push code when implementing force push for the Terraform remote backend, a bug was introduced that meant that backends that don't implement the EnableForcePush method would still have their state validated. This commit fixes that, and adds test coverage such that there is a separate mockRemoteClient that has this method implemented.
pselle
force-pushed
the
pselle/force-push-fix
branch
from
9d90bd6
to
2c35869
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In refactoring the
state push -forcecode when implementing force push for the Terraform remote backend, a bug was introduced that meant that backends that don't implement theEnableForcePushmethod would still have their state validated, despite having-forceset.This commit fixes that, and adds test coverage such that there is a separate mockRemoteClient that has this method implemented. I had trouble thinking of a way to simplify the tests that doesn't make it needlessly complicated. The tests fail without the change in state.go.
Closes #25761
I nominate this change to go to v0.13 as well, as it is a bug fix for existing versions worthy of cherry-picking.