provider/aws: Allow ELB name to be generated #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elbName = v.(string) | ||
| } else { | ||
| elbName = resource.PrefixedUniqueId("tf-lb-") | ||
| d.Set("name", elbName) |
There was a problem hiding this comment.
This is here because of update function being called at the end, it feels a bit dirty, but I can't think of better/cleaner solution right now.
This was referenced Jul 6, 2015
|
LGTM |
catsby
added a commit
that referenced
this pull request
Jul 21, 2015
provider/aws: Allow ELB name to be generated
|
In a slight breach of etiquette, I merged this and updated the CHANGELOG, sorry :( Thanks 😄 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ELB has a hard limit of 32 characters, it may be sometimes hard to come up with a unique name, so user may end up just using tags for human labels, but the name still need to be filled in with something unique (although useless for humans).
This PR is adding new helper - indirectly related to #2269 and makes elb name optional - i.e. generated as
tf-lb-UNIQUE_ID.I can add an acceptance test case for ELB w/out a name, but first I want to get general feedback on this idea.