Upgrade hcl and go-cty

[alisdair]

Upgrades:

• hcl v2.6.0: https://github.com/hashicorp/hcl/releases/tag/v2.6.0
• cty v1.5.0: https://github.com/zclconf/go-cty/releases/tag/v1.5.0

Issues:

• Fixes Argument expansion error in output expression during validation walk #22404
• Fixes Terraform console crashes when passing incorrect arguments to setsubtract() function #24377
• Fixes “panic: runtime error: index out of range” using a combination of null and splat #24805
• Fixes Crash when using terraform_remote_state data source #25150

[codecov]

Codecov Report

Merging #25216 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
states/statefile/version4.go	58.16% <0.00%> (+0.28%)	⬆️
terraform/evaluate.go	53.60% <0.00%> (+0.45%)	⬆️
dag/marshal.go	53.40% <0.00%> (+1.13%)	⬆️

[mildwonkey]

🎉 I have a small list of issues that should also be closed with this PR, too! 🎉

[alisdair]

@mildwonkey I tried to spelunk for all the related issues I could find, but I could have missed some! Feel free to add others to the PR description or otherwise link them.

[grobie]

@alisdair @jbardin Thanks for this! Will this be part of the next Terraform version? I ran into a Terraform crash when using the hashicorp/terraform-provider-kubernetes-alpha provider, and it seems it's also the result of zclconf/go-cty#55

panic: interface conversion: interface {} is *cty.unknownType, not bool

[alisdair]

@grobie Yes, this dependency upgrade will be released in Terraform 0.13.0-beta2.

[grobie]

@alisdair Thanks. It appears Terraform 0.13.0 is still not advised to be used in production and some time out. Any chance to release a new 0.12.x version with the fixes for these terraform panics? It's really hard to use the current kubernetes-alpha provider as Terraform always crashes when attempting to render a diff for a K8s deployment.

[alisdair]

We do not currently have plans to release another 0.12.x version. All our efforts are on releasing 0.13.0, hopefully in just a few weeks time.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.