provider/aws: Add cloudwatch_log_group

[radeksimko]

Status

• Reading existing group precisely (probably will have to look up in returned list)
• Deleting group
• Creating group
• Docs
• Acceptance tests

This should make #2384 much more useful.

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=CloudWatchLogGroup' 2>~/tf.log

go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=CloudWatchLogGroup -timeout 90m
=== RUN TestAccAWSCloudWatchLogGroup_basic
--- PASS: TestAccAWSCloudWatchLogGroup_basic (20.78s)
=== RUN TestAccAWSCloudWatchLogGroup_retentionPolicy
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (35.24s)
=== RUN TestAccAWSCloudWatchLogGroup_multiple
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (16.42s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    72.460s

cc @catsby

[radeksimko]

This is now ready for review.

[josephholsten]

@phinze 👀

[catsby]

This is fine to leave, but for future reference, regular attributes do not need to be dereferenced when using d.Set.
Setting the ID with d.SetId still does, however.

[radeksimko]

Ah, good point. I will keep that in mind for next time.

[catsby]

LGTM, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.