NodeDestroyResource does not need a provider #23696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource cleanup node does not need a provider. We can't directly remove the ProvidedBy method, but this node only needs to be eval-able so we can remove all the NodeAbstractResource methods at once.
ghost
added
the
sdkv1
mildwonkey
approved these changes
Dec 17, 2019
jbardin
added a commit
that referenced
this pull request
Jan 9, 2020
The change in #23696 removed the NodeAbstractResource methods from the NodeDestroyResource type, in order to prevent other resource behaviors, like requesting a provider. While this node type is not directly referenced, it was implicitly ordered against the module cleanup by virtue of being a resource node. The ReferenceTransformer uses the GraphNodeReferenceable and GraphNodeSubPath interfaces to add nodes to the reference map, so we need to re-add the relevant methods. Since there's no good entry point to test this ordering at the moment, add static checks for the interfaces, and document where these interfaces are required.
jbardin
added a commit
that referenced
this pull request
Jan 9, 2020
The change in #23696 removed the NodeAbstractResource methods from the NodeDestroyResource type, in order to prevent other resource behaviors, like requesting a provider. While this node type is not directly referenced, it was implicitly ordered against the module cleanup by virtue of being a resource node. The ReferenceTransformer uses the GraphNodeReferenceable and GraphNodeSubPath interfaces to add nodes to the reference map, so we need to re-add the relevant methods. Since there's no good entry point to test this ordering at the moment,
jbardin
added a commit
that referenced
this pull request
Jan 9, 2020
The change in #23696 removed the NodeAbstractResource methods from the NodeDestroyResource type, in order to prevent other resource behaviors, like requesting a provider. While this node type is not directly referenced, it was implicitly ordered against the module cleanup by virtue of being a resource node. The ReferenceTransformer uses the GraphNodeReferenceable and GraphNodeSubPath interfaces to add nodes to the reference map, so we need to re-add the relevant methods. Since there's no good entry point to test this ordering at the moment,
jbardin
added a commit
that referenced
this pull request
Jan 10, 2020
The change in #23696 removed the NodeAbstractResource methods from the NodeDestroyResource type, in order to prevent other resource behaviors, like requesting a provider. While this node type is not directly referenced, it was implicitly ordered against the module cleanup by virtue of being a resource node. Since there's no good entry point to test this ordering at the moment,
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource cleanup node does not need a provider. We can't directly
remove the ProvidedBy method, but this node only needs to be eval-able so
we can remove all the NodeAbstractResource methods at once.
Fixes #23671
Fixes #22758