Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on show plan #23581

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Fix panic on show plan #23581

merged 2 commits into from
Dec 6, 2019

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Dec 5, 2019

Don't inspect an empty set, return false

Fixes #23377

@ghost ghost added the sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK label Dec 5, 2019
@pselle pselle requested a review from a team December 5, 2019 21:13
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pselle pselle merged commit d8c31a1 into master Dec 6, 2019
@pselle pselle deleted the pselle/show-panic-23377 branch December 6, 2019 17:08
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform 0.12.14 panic during show plan
2 participants