Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filesystem unlock err #23336

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Update filesystem unlock err #23336

merged 1 commit into from
Nov 11, 2019

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Nov 11, 2019

Looks like multierror.Append(idErr, err) is assigned to the err variable which is not used/returned the so updated it to idErr.

@ghost ghost added the sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK label Nov 11, 2019
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 11, 2019

CLA assistant check
All committers have signed the CLA.

@apparentlymart
Copy link
Contributor

Hi @aqche! Thanks for finding and fixing this.

Indeed, it does look like the assignment to err here was incorrect and that assigning to idErr is what was intended. Thanks again!

@apparentlymart apparentlymart merged commit bcaf7f7 into hashicorp:master Nov 11, 2019
@aqche
Copy link
Contributor Author

aqche commented Nov 12, 2019

@apparentlymart happy to help!

@aqche aqche mentioned this pull request Mar 8, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants