Add edge when calculating for_each orphans #22454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scenario when a resource is orphaned by the addition of for_each, in the evaluation of orphans, it is possible for the EachMode of the resource to be set incorrectly, because the last evaluated resource sets the EachMode for the whole resource. As such, adding an edge when evaluating the movement between NoKey and StringKey resources will ensure order is maintained, and an instance with StringKey will "win".
Fixes #22407