Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE Container Node Pool with sandbox type of gvisor missing label "sandbox.gke.io/runtime" = "gvisor" #22434

Closed
vugardzhamalov opened this issue Aug 12, 2019 · 2 comments

Comments

@vugardzhamalov
Copy link

Hi there,

Terraform Version: 0.12.6
Terraform Resource: google_container_node_pool
Sandbox type: gvisor

It seems that unless explicitly declared in the labels list of container node pool this will not be declared automatically (but I suspect it is expected to be there). My current guess that this might affect node taint as well... But I am not certain.

The missing label is: "sandbox.gke.io/runtime" = "gvisor". If I don't declare it explicitly, this is what I see in my 'terraform plan' output.

`~ node_config {
~ labels = { # forces replacement
- "sandbox.gke.io/runtime" = "gvisor" -> null
}

  • taint {
    - effect = "NO_SCHEDULE" -> null
    - key = "sandbox.gke.io/runtime" -> null
    - value = "gvisor" -> null
    }`

Explicit declaration of this label fixes the issue for me!

@ghost
Copy link

ghost commented Aug 12, 2019

This issue has been automatically migrated to hashicorp/terraform-provider-google#4210 because it looks like an issue with that provider. If you believe this is not an issue with the provider, please reply to hashicorp/terraform-provider-google#4210.

@ghost ghost closed this as completed Aug 12, 2019
@ghost
Copy link

ghost commented Sep 12, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Sep 12, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants