Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: Update aws/aws-sdk-go to 1.22.0 #22363

Closed
007 opened this issue Aug 6, 2019 · 3 comments
Closed

request: Update aws/aws-sdk-go to 1.22.0 #22363

007 opened this issue Aug 6, 2019 · 3 comments

Comments

@007
Copy link

007 commented Aug 6, 2019

Terraform Version

Terraform v0.12.6

Expected Behavior

Order of precedence for AWS credentials follows CLI precedence

Actual Behavior

Upstream change made AWS_PROFILE override AWS_*_KEY behavior

Steps to Reproduce

I can't reproduce this directly, but I know that this will bite someone who expects AWS CLI precedence. I believe setting AWS_PROFILE=nonexistent and having AWS_*_KEY values set to valid key+secret will show the behavior.

Additional Context

This may affect terraform-provider-aws too, but I haven't investigated which version of aws-sdk-go it is using.

References

#22253 changed the behavior by pulling the then-current [email protected], the newest upstream release is [email protected] which changes the precedence back (closer) to CLI order.

@teamterraform
Copy link
Contributor

Hi @007,

Thanks for filing this.
Core actually depends on the AWS provider, so as to ensure that the client behavior matches.
Once the AWS provider is updated, we can pull the new dependencies from there.

@bflad
Copy link
Contributor

bflad commented Apr 22, 2020

It appears this may have been resolved awhile ago -- the AWS Go SDK dependency on master is v1.25.3 and will soon be updated to v1.30.12. If there are still lingering issues on the latest version of the Terraform CLI, please do not hesitate to open a new issue and we will take a fresh look. 👍

@bflad bflad closed this as completed Apr 22, 2020
@ghost
Copy link

ghost commented May 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants