provider/aws: fix panic when route has no cidr_block #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -361,7 +361,10 @@ func resourceAwsRouteTableDelete(d *schema.ResourceData, meta interface{}) error | |||
| func resourceAwsRouteTableHash(v interface{}) int { | |||
| var buf bytes.Buffer | |||
| m := v.(map[string]interface{}) | |||
| buf.WriteString(fmt.Sprintf("%s-", m["cidr_block"].(string))) | |||
|
|
|||
| if v, ok := m["cidr_block"]; ok { | |||
There was a problem hiding this comment.
doest this need to check for v.(string) != "" as well ?
There was a problem hiding this comment.
oh whoops - didn't change next line to use v - this would technically work but it's silly.
empty string is fine - you'll just generate a hash from the string w/ two dashes in it
There was a problem hiding this comment.
ah, at least gets around nil pointer 👍
|
🚀 |
phinze
force-pushed
the
b-route-cidr-block-optional
branch
from
ccfe468 to
cd434c3
Compare
|
LGTM! 👍 |
While cidr_block is required for static route creation, there are apparently cases (involving some combination of VPNs, Customer Gateways, and automatic route propogation) where the cidr_block can come back nil. This means we cannot assume it's there in the set hash calculation.
phinze
force-pushed
the
b-route-cidr-block-optional
branch
from
cd434c3 to
1caef30
Compare
phinze
added a commit
that referenced
this pull request
Jun 3, 2015
provider/aws: fix panic when route has no cidr_block
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While cidr_block is required for static route creation, there are
apparently cases (involving some combination of VPNs, Customer Gateways,
and automatic route propogation) where the cidr_block can come back nil.
This means we cannot assume it's there in the set hash calculation.