Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic set blocks produce inconsistent final plan #22057

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Jul 12, 2019

AssertObjectCompatible needs to detect possible dynamic NestingSet blocks, and ignore changes in set length. This check was already present in the NestingList case.

Fixes #22048

@jbardin jbardin requested a review from a team July 12, 2019 20:37
@jbardin jbardin force-pushed the jbardin/dynamic-set-blocks branch from 1bc7713 to 8da6c0e Compare July 12, 2019 20:39
plans/objchange/compatible.go Outdated Show resolved Hide resolved
jbardin added 2 commits July 12, 2019 16:48
If a planned NestingList block value looks like it may represent a
dynamic block, we don't check the length since it may be unknown. This
check was missing in the NestingSet case, but it applies for the same
reason.

<
@jbardin jbardin force-pushed the jbardin/dynamic-set-blocks branch from 8da6c0e to efd2a6c Compare July 12, 2019 20:49
@jbardin jbardin merged commit 366f8c1 into master Jul 12, 2019
@jbardin jbardin deleted the jbardin/dynamic-set-blocks branch July 12, 2019 21:10
@ghost
Copy link

ghost commented Aug 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Provider produced inconsistent final plan in 0.12.3
2 participants