Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hcl2 #21957

Merged
merged 1 commit into from
Jul 3, 2019
Merged

update hcl2 #21957

merged 1 commit into from
Jul 3, 2019

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Jul 2, 2019

This includes a fix for more precise resolution of types from conditional statements. This prevents null literals from forcing the evaluated type to always be dynamic.

Fixes #21395
Fixes #21465
Fixes #21745
Fixes #21450

@jbardin jbardin added the config label Jul 2, 2019
@jbardin jbardin requested a review from a team July 2, 2019 19:14
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't let this question block merging, but are there any useful test cases we should add ... somewhere? ... to guard against regression?

@jbardin
Copy link
Member Author

jbardin commented Jul 3, 2019

The change is really isolated to the hcl2 conditional expression, so any tests here would just be duplicating the tests already in the hcl2 package.

@ghost
Copy link

ghost commented Aug 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants